[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] {master} missing: do not touch timestamps; only warn for out
From: |
Eric Blake |
Subject: |
Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files |
Date: |
Mon, 25 Jun 2012 21:52:40 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 06/25/2012 09:46 PM, Eric Blake wrote:
>
>> case $1 in
>> ---run)
>> - # Try to run requested program, and just exit if it succeeds.
>> - run=
>> - shift
>> - "$@" && exit 0
>> - # Exit code 63 means version mismatch. This often happens
>> - # when the user try to use an ancient version of a tool on
>> - # a file that requires a minimum version. In this case we
>> - # we should proceed has if the program had been absent, or
>> - # if --run hadn't been passed.
>> - if test $? = 63; then
>> - run=:
>> - msg="probably too old"
>> - fi
>> - ;;
>
> Ouch. You've broken programs that use automake < 1.12 but which pull in
> the latest build-aux scripts via gnulib, since older automake hard-coded
> the use of the --run argument:
This appears to be sufficient for my needs, although I've just hacked it
locally instead of preparing a formal patch:
--- ../gnulib/build-aux/missing 2012-06-25 21:38:39.031914248 -0600
+++ build-aux/missing 2012-06-25 21:50:59.075528749 -0600
@@ -1,7 +1,7 @@
#! /bin/sh
# Common wrapper for a few potentially missing GNU programs.
-scriptversion=2012-06-14.10; # UTC
+scriptversion=2012-06-26.03; # UTC
# Copyright (C) 1996-2012 Free Software Foundation, Inc.
# Originally written by Fran,cois Pinard <address@hidden>, 1996.
@@ -39,6 +39,10 @@
case $1 in
+ --run)
+ shift
+ ;;
+
--is-lightweight)
# Used by our autoconf macros to check whether the available missing
# script is modern enough.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files, Eric Blake, 2012/06/25
- Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files,
Eric Blake <=
- Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files, Stefano Lattarini, 2012/06/26
- Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files, Bruno Haible, 2012/06/26
- Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade (was: Re: [PATCH] {master} missing: do not touch timestamps; only warn for out-of-date files), Stefano Lattarini, 2012/06/26
- Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade, Eric Blake, 2012/06/26
- Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade, Stefano Lattarini, 2012/06/26
- Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade, Eric Blake, 2012/06/26
- Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade, Stefano Lattarini, 2012/06/26
Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade, Bruno Haible, 2012/06/26
Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade, Eric Blake, 2012/06/26
Re: Automake-installed auxiliary scripts can get silently out-of-date after an Automake upgrade, Eric Blake, 2012/06/26