[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[FYI] {maint} tests: avoid several spurious failures on Solaris
From: |
Stefano Lattarini |
Subject: |
[FYI] {maint} tests: avoid several spurious failures on Solaris |
Date: |
Sun, 24 Jun 2012 18:50:15 +0200 |
* t/ax/is_newest: Rewrite to be Bourne-compatible, for /bin/sh shells like
Solaris' that are not POSIX-conforming. The script is so small that such
a rewrite is easier than going through the hoops that would be required to
ensure this script is always executed with a POSIX shell.
* t/ax/is: Add a comment stating that this script is to be kept Bourne
compatible as well.
Signed-off-by: Stefano Lattarini <address@hidden>
---
t/ax/is | 3 +++
t/ax/is_newest | 8 +++++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/t/ax/is b/t/ax/is
index 1e1c0ce..4f043ca 100755
--- a/t/ax/is
+++ b/t/ax/is
@@ -21,6 +21,9 @@
# in the face of variables defined through line-continuations,
# automake rewrites and expansions of empty variables.
+# NOTE: keep this file Bourne-compatible, for the sake of systems with
+# non-POSIX /bin/sh (like Solaris).
+
set -e
set -u
diff --git a/t/ax/is_newest b/t/ax/is_newest
index f52a1a8..cd1a38e 100755
--- a/t/ax/is_newest
+++ b/t/ax/is_newest
@@ -16,8 +16,10 @@
# Usage: is_newest FILE FILES
# Fail if any file in FILES is newer than FILE, and print the list of
-# such files on the standard error.
-# Resolve ties in favor of FILE.
+# such files on the standard error. Resolve ties in favor of FILE.
+
+# NOTE: keep this file Bourne-compatible, for the sake of systems with
+# non-POSIX /bin/sh (like Solaris).
set -u
@@ -29,7 +31,7 @@ if test $# -lt 2; then
fi
file=$1; shift
-newer_files=$(find "$@" -prune -newer "$file") || exit $?
+newer_files=`find "$@" -prune -newer "$file"` || exit $?
if test -n "$newer_files"; then
echo "$me: these files are newer than '$file':" >&2
--
1.7.9.5
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [FYI] {maint} tests: avoid several spurious failures on Solaris,
Stefano Lattarini <=