[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/8] tags: new var $(am__tagged_files) to list all files to r
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH 3/8] tags: new var $(am__tagged_files) to list all files to run taggers on |
Date: |
Fri, 08 Jun 2012 21:27:07 +0200 |
On 06/08/2012 10:20 AM, Stefano Lattarini wrote:
> This change reduce code duplication a little, and will be needed by
> future simplifications.
>
> * automake.in (handle_tags): Define a new 'am__tagged_files' private
> make variable that lists all files to run taggers (mkid, cscope, ctags,
> etc) on.
> * lib/am/tags.am: Use it in several recipes and dependencies list to
> reduce code duplication.
>
Hmpf, this patch uselessly kept some duplicated code; consider the hunk
below squashed in, which should solve the issue.
Sorry for the noise,
Stefano
-*-*-*-
diff --git a/automake.in b/automake.in
index cd3d7bc..864f70f 100644
--- a/automake.in
+++ b/automake.in
@@ -3667,18 +3667,6 @@ sub handle_tags
|| var ('ETAGS_ARGS')
|| @tag_deps)
{
- my @config;
- foreach my $spec (@config_headers)
- {
- my ($out, @ins) = split_config_file_spec ($spec);
- foreach my $in (@ins)
- {
- # If the config header source is in this directory,
- # require it.
- push @config, basename ($in)
- if $relative_dir eq dirname ($in);
- }
- }
$output_rules .= &file_contents ('tags',
new Automake::Location,
CONFIG => "@config",
- [PATCH 0/8] {master} Some simplifications in tags support, Stefano Lattarini, 2012/06/08
- [PATCH 3/8] tags: new var $(am__tagged_files) to list all files to run taggers on, Stefano Lattarini, 2012/06/08
- Re: [PATCH 3/8] tags: new var $(am__tagged_files) to list all files to run taggers on,
Stefano Lattarini <=
- [PATCH 4/8] tags: look at $(am__tagged_files) to decide whether to activate, Stefano Lattarini, 2012/06/08
- [PATCH 1/8] tags (ID, cscope): also process config header (if any), Stefano Lattarini, 2012/06/08
- [PATCH 2/8] tags (cscope): also process $(TAGS_FILES), Stefano Lattarini, 2012/06/08
- [PATCH 8/8] cleanup: simplify subroutine '&saw_extension', Stefano Lattarini, 2012/06/08
- [PATCH 6/8] cleanup: remove unused '&count_files_for_language' subroutine, Stefano Lattarini, 2012/06/08
- [PATCH 5/8] automake: simplify '&saw_sources_p', Stefano Lattarini, 2012/06/08
- [PATCH 7/8] cleanup: remove subroutine '&saw_sources_p', Stefano Lattarini, 2012/06/08
- Re: [PATCH 0/8] {master} Some simplifications in tags support, Stefano Lattarini, 2012/06/09