[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] silent-many-generic: be stricter in silent rules pattern
From: |
Dave Goodell |
Subject: |
Re: [PATCH] silent-many-generic: be stricter in silent rules pattern |
Date: |
Tue, 28 Feb 2012 13:52:43 -0600 |
Your patch does not work for me. Attached is a fixed version of your patch
that matches the offending $CXX value correctly, handles spaces in compiler
wrapper arguments, and fixes a typo.
If you have a better alternative to the conservative "case" statement that I
used, please use it. Between the recommendations in the autoconf manual and
the recent thread on autoconf@ about ${1+"$@"}, I'm a bit unsure about the best
way to proceed besides using the case block.
-Dave
0001-tests-fix-spurious-failure-with-Portland-Compilers.patch
Description: Binary data
On Feb 28, 2012, at 10:18 AM CST, Stefano Lattarini wrote:
> Hi Dave, thanks for the patch.
>
> It turns out we have already in place a workaround for a situation
> similar to the one you're facing (that situation being the Sun C++
> compiler being named 'CC'). So the best fix IMO is to extend this
> workaround to deal also with you case. The attached patch should do
> so. Can you confirm it fixes your issue?
>
> Thanks,
> Stefano
> <0001-tests-fix-spurious-failure-with-Portland-Compilers.patch>