automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hacking: document format for git commit messages


From: Jim Meyering
Subject: Re: [PATCH] hacking: document format for git commit messages
Date: Sun, 26 Feb 2012 08:53:17 +0100

Stefano Lattarini wrote:

> On 02/25/2012 08:38 PM, Stefano Lattarini wrote:
>>
>> But I should definitely improve HACKING and have it document the
>> standards and best practice for commit logs (since the GCS are sadly
>> weak and out-of-date in this regard).
>>
> And here is my attempt.  WDYT?  I will push in a couple of days if there
> is no objection.
>
...
> +
> +      Finally, here you can thank people that motivated of helped the

s/of/or/

> +      change.  So, thanks to John Doe for bringing up the issue, and to
> +      J. Random Hacker for providing suggestions and testing the patch.
> +
> +      <detailed list of touched files>
> +
> +      Signed-off-by: A. U. Thor <address@hidden>

Do you really want to start requiring a Signed-off-by line, now?
I explicitly avoid such lines as redundant when they merely repeat
what's on the Author: line.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]