Re: [PATCH] tests: prefer 'configure.ac' over 'configure.in'

[Stefano Lattarini]

Hi Peter.

On 02/22/2012 08:31 PM, address@hidden wrote:
>> On 02/21/2012 09:56 PM, Stefano Lattarini wrote:
>>> With this change, our testsuite now uses 'configure.ac' as the
>>> name for the typical autoconf input, instead of the obsolescent
>>> 'configure.in' (which has been deprecated for several years, at
>>> least since autoconf 2.50).
>>>
>>> The test cases changed by this commit have been automatically
>>> modified with this sed command (using GNU sed):
>>>
>>>   sed -i 's/\<configure\(\\\?\)\.in\>/configure\1.ac/g'
>>>
>>> I will push by tomorrow if there is no objection.
>>>
>> I've now pushed the patch, with few minor adjustments.
> 
> A bit late as usual, but I assume the pr???.tests were also
> modified?
>
Yes.

> If they were, was that intentional?
>
Yes.

> If it was intentional, would it also be ok to modify the tests
> that need help with ar-lib related problems (would fix a few
> FAILs)?
>
Which FAILs exactly?  I've experienced none (but then again, the
MinGW/MSYS specifc tests are always skipped on my systems).  Also,
I've added a new maintainer check 'sc_tests_no_configure_in' to
ensure we don't have unwarranted uses of 'configure.in' anymore
in our tests, and that is not returning any diagnostic; is this
check somehow incomplete or busted?

Thanks,
  Stefano