[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] parallel-tests: fix another BSD parallel make issue
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] parallel-tests: fix another BSD parallel make issue |
Date: |
Sat, 18 Feb 2012 23:12:11 +0100 |
On 02/18/2012 02:09 PM, Stefano Lattarini wrote:
> [CC:ing bug-autoconf for Yet Another BSD make Bug, in case someone
> cares to documenting it ...]
>
> When BSD make is run in parallel mode, it apparently strips any leading
> directory component from the automatic variable '$*' (of course, against
> what POSIX mandates). This is causing FreeBSD 9.0 make and NetBSD 5.1
> make to spuriously fail with automake-generated test harnesses if subdir
> tests are present *and* make is being run in parallel mode. This issue
> affects also the Automake own testsuite.
>
> The attached patch should work around the problem.
>
> I will test this patch more properly in the next few days, and apply it
> if it causes no regression. I'm posting it here in case anyone can spare
> some time to eyeball it, give early feedback, or even test the patch.
>
Oh, and this fix deserves a NEWS entry. Here is what I've squashed in:
diff --git a/NEWS b/NEWS
index 252fcf7..c1de9b2 100644
--- a/NEWS
+++ b/NEWS
@@ -154,6 +154,12 @@ Bugs fixed in 1.11a:
- The AM_COND_IF macro also works if the shell expression for the
conditional is no longer valid for the condition.
+ - The automake-provided parallel testsuite harness does not fail anymore
+ with BSD make used in parallel mode when there are test scripts in a
+ subdirectory, like in:
+
+ TESTS = sub/foo.test sub/bar.test
+
* Long-standing bugs:
- Automake's own build system finally have a real "installcheck" target.
Regards,
Stefano