Re: [PATCH] tests: check if 'compress' is real of fake

[Peter Rosin]

Stefano Lattarini skrev 2012-02-09 10:09:
> Hi Peter.
> 
> On 02/08/2012 10:24 PM, Peter Rosin wrote:
>> diff --git a/tests/dist-formats.tap b/tests/dist-formats.tap
>> index dd9d896..629d615 100755
>> --- a/tests/dist-formats.tap
>> +++ b/tests/dist-formats.tap
>> @@ -78,7 +78,11 @@ echo All compressors: $all_compressors
>>  # Assume gzip(1) is available on every reasonable portability target.
>>  missing_compressors=`
>>    for c in $all_compressors; do
>> -    test $c = gzip || $c --version </dev/null >&2 && continue
>> +    case $c in
>> +      gzip)     continue;;
>> +      compress) $c -c </dev/null >/dev/null && continue;;
>>
> You should add the explanation given in the commit message here as
> well:
> 
>       # On Cygwin x.y.z, 'compress' is provided by sharutils and is
>       # just a dummy script that is not able to actually compress (it
>       # can only decompress).  So check that the 'compress' program
>       # is actually able to compress input.
>       compress) $c -c </dev/null >/dev/null && continue;;
> 
> At which point you can also move the comment "Assume gzip(1) is
> available on every reasonable portability target" just above the
> "gzip)" entry, for consistency and clarity.

Fixed and pushed, thanks for looking!

FYI, since this is not really related to any particular version of
the Cygwin DLL, saying Cygwin 1.7.10 would be misleading.  It's
more the version of the distribution that we're after, but since
the Cygwin dist is just a continuing work in progress the date is
the only valid identifier.  Thus, I used this comment:

      # On Cygwin, as of 9/2/2012, 'compress' is provided by sharutils
      # and is just a dummy script that is not able to actually compress
      # (it can only decompress).  So, check that the 'compress' program
      # is actually able to compress input.


PS: the only testsuite FAILs left (that I see) with up-to-date Cygwin
is bug#10766 "CXX gets the value 'CC' on Cygwin, but CC is in fact cc".

Cheers,
Peter