automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] hacking: miscellaneous minor fixes


From: Stefano Lattarini
Subject: Re: [PATCH 1/7] hacking: miscellaneous minor fixes
Date: Mon, 5 Dec 2011 23:00:43 +0100
User-agent: KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; )

On Monday 05 December 2011, Peter Rosin wrote:
> Hi!
>
Hi Peter, thanks for the feedback.  Always appreciated.

> This caught my eye...
> 
> [SNIP]
>
> >    appropriate paperwork.
> >    Second, be sure to add their name and email address to THANKS
> >  
> >  * If a change fixes a test, mention the test in the ChangeLog entry.
> > +  If a change fixes a bug registered in the Automake debbugs tracker,
> > +  mention the bug number in the ChangeLog entry.
> 
> *snip*
> 
> There is now no longer any mention of the case where a change fixes a
> test, but where there is no open bug to mention. Was that intended?
>
> Also, the asterisk went missing.
>
I think you are misreading the diff; the line:
  "If a change fixes a test, mention the test in the ChangeLog entry."
has *not* been removed; it just happens that the next line starts with
its exact same words ("If a change fixes a").  I don't find this
confusing, but if you do, feel free to suggest alternative wordings.

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]