automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FYI] {msvc} tests: various minor tweakings, mostly related to AM_PR


From: Peter Rosin
Subject: Re: [FYI] {msvc} tests: various minor tweakings, mostly related to AM_PROG_AR
Date: Tue, 08 Nov 2011 22:52:17 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1

Stefano Lattarini skrev 2011-11-03 15:15:
> * tests/alloca.test: Adjust to new portability requirements due
> to the new AM_PROG_AR macro.
> * tests/discover.test: Likewise.
> * tests/libobj3.test: Likewise.
> * tests/pluseq7.test: Likewise.  Also, make grepping of automake
> expected error message stricter.
> * tests/stdlib.test: Likewise, and extend the test a bit.
> * tests/parse.test (configure.in): Remove redundant call to
> AC_PROG_RANLIB.
> * tests/library2.test: Adjust to new portability requirements
> due to the new AM_PROG_AR macro.  Also ...
> (configure.in): ... add call to AC_PROG_CC, to ensure automake
> really fails for the expected reason.

Some of these changes are strictly speaking not new portability
_requirements_. But if you indeed think these changes are important,
you'd also want to fix e.g. alloca2.test (quite possibly others as
well, but I have scanned through the tests too many times for
AM_PROG_AR issues to do it once more without good reason). I'm
mostly curious why you have changed these tests, which had the
pattern "don't care if automake fails in one more way since I'm
greping for the error message anyway" and instead desire them to
keep quiet about extra-portability stuff. The changes seem really
pedantic IMHO.

Cheers,
Peter



reply via email to

[Prev in Thread] Current Thread [Next in Thread]