automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] {test-protocols} tests: fix spurious failure for awk implementatio


From: Stefano Lattarini
Subject: [FYI] {test-protocols} tests: fix spurious failure for awk implementation of TAP driver
Date: Fri, 26 Aug 2011 11:16:08 +0200

* tests/tap-realtime.test: The awk+shell implementation of the TAP
driver must "read ahead" of one line in order to catch the exit
status of the test script it runs.  So, in the TAP-producer script
here, be sure to echo one "dummy" line after each TAP result line
in order not to cause false positives.
---
 ChangeLog               |    9 +++++++++
 tests/tap-realtime.test |    8 ++++++++
 2 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e407d89..666445a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2011-08-26  Stefano Lattarini  <address@hidden>
+
+       tests: fix spurious failure for awk implementation of TAP driver
+       * tests/tap-realtime.test: The awk+shell implementation of the TAP
+       driver must "read ahead" of one line in order to catch the exit
+       status of the test script it runs.  So, in the TAP-producer script
+       here, be sure to echo one "dummy" line after each TAP result line
+       in order not to cause false positives.
+
 2011-08-25  Stefano Lattarini  <address@hidden>
 
        tap/awk: allow escaping of TAP directives
diff --git a/tests/tap-realtime.test b/tests/tap-realtime.test
index 4a38f14..61476c3 100755
--- a/tests/tap-realtime.test
+++ b/tests/tap-realtime.test
@@ -47,15 +47,23 @@ echo 1..3
 # FIXME: creative quoting to placate maintainer-check
 sleep="sleep "3
 
+# The awk+shell implementation of the TAP driver must "read ahead" of one
+# line in order to catch the exit status of the test script it runs.  So
+# be sure to echo one "dummy" line after each result line in order not to
+# cause false positives.
+
 echo ok 1 - foo
+echo DUMMY
 $sleep
 test -f ok-1 || { echo 'Bail out!'; exit 1; }
 
 echo ok 2 - bar
+echo DUMMY
 $sleep
 test -f ok-2 || { echo 'Bail out!'; exit 1; }
 
 echo ok 3 - baz
+echo DUMMY
 $sleep
 test -f ok-3 || { echo 'Bail out!'; exit 1; }
 
-- 
1.7.2.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]