automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ylwrap: fix unusual indentation whitespace


From: Stefano Lattarini
Subject: Re: [PATCH] ylwrap: fix unusual indentation whitespace
Date: Thu, 25 Aug 2011 20:56:32 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

Hi Eric, thanks for the patch.

On Thursday 25 August 2011, Eric Blake wrote:
> On 08/25/2011 12:41 PM, Eric Blake wrote:
> > * lib/ylwrap: Convert to spaces.
> > Reported by Karl Berry.
> >
> > Signed-off-by: Eric Blake<address@hidden>
> > ---
> >
> > I'm assuming that getting rid of space-tab is trivial enough to
> > just push, so I'll apply this to maint, then merge into
> > branch-1.11 and master.
> 
> But only after first fixing the commit message to mention:
> 
> >
> >   ChangeLog  |    5 +++++
> >   lib/ylwrap |   28 ++++++++++++++--------------
> >   2 files changed, 19 insertions(+), 14 deletions(-)
> >
> > diff --git a/ChangeLog b/ChangeLog
> > index 2ad9390..30b89dd 100644
> > --- a/ChangeLog
> > +++ b/ChangeLog
> > @@ -1,3 +1,8 @@
> > +2011-08-25  Eric Blake<address@hidden>
> > +
> > +   ylwrap: fix unusual indentation whitespace
> > +   * lib/ylwrap: Convert to spaces.
> 
> convert _tabs_ to spaces.
> 
> 
While I always welcome tabs->spaces conversions, consider that the
`ylwrap' script has been vasically rewritten in the `ylwrap-refactor'
branch, that I plan to merge to master (but obviously not in maint)
eventually.  Have you merged your changes to that branch too?  If
not, the suggested way to do so is to merge `maint' in `yacc-work',
then merge `yacc-work' in `ylwrap-refactor'.  Or I can do that for
you if you want.

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]