Re: [FYI] {test-protocols} parallel-tests: work around Solaris XPG4 make segfault

[Stefano Lattarini]

On Monday 08 August 2011, Stefano Lattarini wrote:
> Issue exposed by test `posixsubst-tests-p.test', and similar to
> the problem solved by commit `v1.11-159-ge7aa360'.
> 
> * lib/am/check.am [%?PARALLEL_TESTS%] (check-TESTS): Trim trailing
> whitespace from $list, to avoid triggering a nasty bug (potential
> segfault) on Solaris XPG4 make and Heirloom make.
> ---
>  ChangeLog       |    9 +++++++++
>  lib/am/check.am |    3 +++
>  2 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index d50418d..e715e89 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,14 @@
>  2011-08-07  Stefano Lattarini  <address@hidden>
>  
> +     parallel-tests: work around Solaris XPG4 make segfault
> +     Issue exposed by test `posixsubst-tests-p.test', and similar to
> +     the problem solved by commit `v1.11-159-ge7aa360'.
> +     * lib/am/check.am [%?PARALLEL_TESTS%] (check-TESTS): Trim trailing
> +     whitespace from $list, to avoid triggering a nasty bug (potential
> +     segfault) on Solaris XPG4 make and Heirloom make.
> +
> +2011-08-07  Stefano Lattarini  <address@hidden>
> +
>       testsuite: fix weird spurious failure with Solaris /bin/sh
>       Solaris /bin/sh, when killed with a SIGTERM or SIGINT signal, can
>       apparently end up exiting with exit status 208, instead of leaving
> diff --git a/lib/am/check.am b/lib/am/check.am
> index 8340850..840914a 100644
> --- a/lib/am/check.am
> +++ b/lib/am/check.am
> @@ -294,6 +294,9 @@ check-TESTS:
>       list=`for f in $$list; do                                       \
>         test .log = $$f || echo $$f;                                  \
>       done | tr '\012\015' '  '`;                                     \
> +## This apparently useless munging helps to avoid a nasty bug (a
> +## segmentation fault!) on Solaris XPG4 make.
> +     list=`echo "$$list" | sed 's/ *$$//'`;                          \
>       $(MAKE) $(AM_MAKEFLAGS) $(TEST_SUITE_LOG) TEST_LOGS="$$list"
>  
>  AM_RECURSIVE_TARGETS += check
> 
Oops, I had forgotten to regenerate the Makefile.in files!
Consider this squashed in:

  diff --git a/lib/Automake/tests/Makefile.in b/lib/Automake/tests/Makefile.in
  index ad08b66..fc0ccf8 100644
  --- a/lib/Automake/tests/Makefile.in
  +++ b/lib/Automake/tests/Makefile.in
  @@ -461,6 +461,7 @@ check-TESTS:
          list=`for f in $$list; do                                       \
            test .log = $$f || echo $$f;                                  \
          done | tr '\012\015' '  '`;                                     \
  +       list=`echo "$$list" | sed 's/ *$$//'`;                          \
          $(MAKE) $(AM_MAKEFLAGS) $(TEST_SUITE_LOG) TEST_LOGS="$$list"
 
   .log.html:
  diff --git a/tests/Makefile.in b/tests/Makefile.in
  index d98f473..3da9cab 100644
  --- a/tests/Makefile.in
  +++ b/tests/Makefile.in
  @@ -1614,6 +1614,7 @@ check-TESTS:
          list=`for f in $$list; do                                       \
            test .log = $$f || echo $$f;                                  \
          done | tr '\012\015' '  '`;                                     \
  +       list=`echo "$$list" | sed 's/ *$$//'`;                          \
          $(MAKE) $(AM_MAKEFLAGS) $(TEST_SUITE_LOG) TEST_LOGS="$$list"
 
  .log.html:

Sorry for the noise,
  Stefano