automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[FYI] {testsuite-work} tests: fix syntax error in 'silentcxx-gcc.test' (


From: Stefano Lattarini
Subject: [FYI] {testsuite-work} tests: fix syntax error in 'silentcxx-gcc.test' (was: [FYI] {testsuite-work} tests: drop useless requirements of 'g++')
Date: Sat, 7 May 2011 15:37:59 +0200
User-agent: KMail/1.13.5 (FreeBSD/8.2-RELEASE; KDE/4.5.5; i386; ; )

Reference:
 <http://lists.gnu.org/archive/html/automake-patches/2011-05/msg00020.html>

On Wednesday 04 May 2011, Stefano Lattarini wrote:
> * tests/lflags2.test ($required): Remove 'g++', as any working
> C++ compiler should be enough, and ./configure will cause the
> test to skip if no working C++ compiler is found.
> * tests/yflags2.test: Likewise.
> * tests/subobj9.test: Likewise.
> * tests/silentcxx.test: Likewise.  Also, do not force depmodes
> that could cause non-GNU C++ compilers to fail.
> * tests/silentcxx-gcc.test: New test, like `silentcxx.test',
> but forcing "fast" gcc depmode (and thus requiring the GNU C++
> compiler).
>
Hmpf, this new test has a stupid typo which is causing a syntax error
in the shell.  I don't know I could have missed that until now.

Fixed by the attached patch, applied to a temporary bug-fixing branch
and merged to testsuite-work.

Sorry for the noise,
  Stefano
From 6bb66ae324675b21e07c0aca297458ae787c95d3 Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Sat, 7 May 2011 14:18:47 +0200
Subject: [PATCH] tests: fix syntax error in 'silentcxx-gcc.test'

* tests/silentcxx-gcc.test (for config_args in ...): Remove extra
trailing backslash from the list of looped-on items.
---
 ChangeLog                |    6 ++++++
 tests/silentcxx-gcc.test |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6021006..495ab56 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-05-07  Stefano Lattarini  <address@hidden>
+
+       tests: fix syntax error in 'silentcxx-gcc.test'
+       * tests/silentcxx-gcc.test (for config_args in ...): Remove extra
+       trailing backslash from the list of looped-on items.
+
 2011-05-04  Stefano Lattarini  <address@hidden>
 
        tests: drop useless requirements of 'g++'
diff --git a/tests/silentcxx-gcc.test b/tests/silentcxx-gcc.test
index bc8beb9..1f5768c 100755
--- a/tests/silentcxx-gcc.test
+++ b/tests/silentcxx-gcc.test
@@ -70,7 +70,7 @@ $FGREP am_cv_CXX_dependencies_compiler_type configure
 # This apparently useless "for" loop is here to simplify the syncing
 # with sister test `silentcxx.test'.
 for config_args in \
-  am_cv_CXX_dependencies_compiler_type=gcc \
+  am_cv_CXX_dependencies_compiler_type=gcc
 do
   ./configure $config_args --enable-silent-rules
   $MAKE >stdout || { cat stdout; Exit 1; }
-- 
1.7.3.5


reply via email to

[Prev in Thread] Current Thread [Next in Thread]