automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing


From: Ralf Wildenhues
Subject: Re: [PATCH] {maint} tests: new subroutines for test skipping/failing
Date: Sun, 17 Apr 2011 20:53:22 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

Hello Stefano,

* Stefano Lattarini wrote on Sun, Apr 17, 2011 at 03:27:17PM CEST:
> Reference:
>   <http://lists.gnu.org/archive/html/automake-patches/2011-03/msg00052.html>
> 
> On Wednesday 30 March 2011, Stefano Lattarini wrote:
> > > > >   $(AM_TESTS_SETUP) $(TESTS_SETUP) $(TESTS_ENVIRONMENT)

I think the AM_TESTS_SETUP naming is not a good one.  It may be
technically more correct than AM_TESTS_ENVIRONMENT, but I think
the latter is the better one simply because it is easier to remember,
and even if you've never heard of it and only know the semantics of
TESTS_ENVIRONMENT, you can have a straightforward way to figure out
how AM_TESTS_ENVIRONMENT would work.

Can we agree to rename it?

Sorry for jumping out now, and for not coming forward with a review
earlier.

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]