[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {maint} tests: improve tests on "maintainer-clean" target

From: Ralf Wildenhues
Subject: Re: [PATCH] {maint} tests: improve tests on "maintainer-clean" target
Date: Thu, 31 Mar 2011 15:46:58 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Thu, Mar 31, 2011 at 03:27:18PM CEST:
> On Wednesday 30 March 2011, Ralf Wildenhues wrote:
> > 
> > A general comment: if you keep on adding tests to maint, it will break
> > branch-1.11 in the long run, in the sense that the branch will not be
> > releasable any more without splitting up the test suite, or improving
> > the test suite driver as discussed before, as it will not work any more
> > on MinGW/MSYS.  Please keep this in mind.
> >
> How much room is left, approximately?

I haven't tested on MinGW recently, and haven't tested branch-1.11 in a
longer while.  The limit was 32K for argv plus environment IIRC.

> I have no big problems in applying
> this patch to master only, but I'd rather keep it in maint unless we are
> already dangerously near to the MinGW/MSYS upper limit.

Well, apply it based on maint, and let's strive for leaving rougly 6K
for tests we may still want to introduce, plus environment.

> > Can we compactify vertically a bit here?

> Well, in fact I had originally compactified this (in maintclean.test),
> but then I thought you would object to the related "diff noise",

Ahh, sorry for being such a jumpy reviewer, and not seeing that that was
a precondition.  With your squash-in is fine; generally, vertical space
is important, but separating off logical bits is important, too.  In
Makefiles, I usually insert an empty line after a rule, at least when no
other rule follows.  That minimizes chances that a stray backslash at
the end of the last rule line causes silent breakage.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]