Re: [PATCH] {maint} tests: fix bug in alloca*.test (was: Re: alloca2 test)

[Ralf Wildenhues]

* Stefano Lattarini wrote on Sat, Mar 05, 2011 at 02:02:33AM CET:
> On Friday 04 March 2011, Patrick Welche wrote:
> > alloca2.test has
> > 
> > grep 'Makefile.am:1:.*AC_PROG_LIBTOOL' stderr
> > 
> > but I think that nowadays LT_INIT is what appears in automake's error
> > message about lack of libtool?
> >
> You're right.  The testcase is in fact failing spuriously.  What about
> the attached patch?  It fixes the new spurious failure, and add a couple
> of improvements to the `alloca*.test' tests.

OK.

Thanks,
Ralf

> Subject: [PATCH] tests: fix bug in alloca*.test
> 
> * tests/alloca.test: Make grepping of automake stderr stricter,
> add a trailing `:' command; also, add AC_PROG_CC to configure.in,
> and create a dummy alloca.c file, to ensure that we fail for the
> proper reason.
> * tests/alloca2.test: Likewise.  Also, look for LT_INIT, not
> AC_PROG_LIBTOOL, in the error message (bug introduced with commit
> v1.11-315-gd51e7b7 "libtool: suggest LT_INIT if LTLIBRARIES
> primary is used").
> 
> From a report by Patrick Welche.