[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] test defs: add subroutine for input unindenting

From: Ralf Wildenhues
Subject: Re: [PATCH] test defs: add subroutine for input unindenting
Date: Wed, 2 Mar 2011 07:27:57 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Tue, Mar 01, 2011 at 07:30:59PM CET:
> On Tuesday 01 March 2011, Peter Rosin wrote:
> > Den 2011-03-01 10:40 skrev Stefano Lattarini:
> > > I'd also like to enhance `self-check-unindent.test' to ensure that
> > > `unindent' remains usable in parallel in the future.  OK to commit
> > > the patch below (to master)?  I'll push in 72 hours if there is no
> > > objection.

No objection from me.

> > One other thing that could conceivable be tested is that unindent
> > behaves as desired when the first non-empty line has only spaces
> > and tabs on it. E.g.

> I've mixed feelings about this.  On the one hand, I'm not sure the
> current semantic is the best one, so it seems better to leave the
> behaviour "unspecified"; on the other hand, this testcase is not
> documentation nor public API, so fixing it would be trivial enough
> in case we later decide to modify the current semantic.  Hmm...

I hope that we don't need to add trailing whitespace to the test suite,
so it should be ok to leave this unspecified.  As Stefano already said,
it's not a big deal either way though.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]