[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Tests initialization: put default definition of AC_CONFI
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH 0/2] Tests initialization: put default definition of AC_CONFIG_AUX_DIR in the pre-populated configure.in. |
Date: |
Tue, 14 Dec 2010 21:29:37 +0100 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
On Tuesday 14 December 2010, Ralf Wildenhues wrote:
> [MEGA-CUT]
> * Stefano Lattarini wrote on Tue, Dec 14, 2010 at 11:18:32AM CET:
> > That this could be a good idea was "confirmed" by the fact that
> > some tests explicitly put a call like:
> > AC_CONFIG_AUX_DIR([.])
> > in the generated configure.in, with a comment reading something
> > like "prevent automake from looking into .. and ../.. when trying
> > to copy required files" (or something of this ilk).
>
> Are you sure most of those are not leftovers from the time where
> tests/defs.in did not copy install-sh into the tree?
>
Thinking about it... probably yes.
Let's just drop [PATCH 1/2] then.
> > That said, I'm not really pushing hard for the [PATCH 1/2], but
> > even if that's rejected, I *really* think we should apply
> > [PATCH 2/2] (with proper amendings) anyway, as it genuinely
> > increases coverage.
>
> Review coming up.
>
I will answer that soonish (this evening or tomorrow).
Thanks,
Stefano
- Re: [PATCH 2/2] Extended tests on AC_CONFIG_AUX_DIR., (continued)
Re: [PATCH 0/2] Tests initialization: put default definition of AC_CONFIG_AUX_DIR in the pre-populated configure.in., Ralf Wildenhues, 2010/12/13