Re: [PATCH] {master} Improve and extend tests on `:=' variable assignments.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Mon, Nov 29, 2010 at 09:09:59PM CET:
> On Monday 29 November 2010, Ralf Wildenhues wrote:
> > I approve the patch but ask you to keep that coverage in, now you update
> > the patch with an unrelated new change whose applicability depends on
> > completely different factors (namely deciding whether some behavior is
> > desirable or not),
> >
> Why should its applicatibility depend on such a decision?  The testcase
> just serves to expose the current behaviour explicitly, without telling
> if it's desirable or not.

IMVHO an entry in the bug tracker is more applicable for issues that may
be valid or invalid.  A commit adding a test that is later removed
because it's invalid is not so easily searched for a couple of years
later.  Closed PRs on the other hand are straightforward to search.

Cheers,
Ralf