Re: Testsuite failures on AIX 5.3

[Stefano Lattarini]

Ralf, could you try the attached patches when you have time, and see
if they fix the issues with ansi.test, colon5.test and colon6.test?

Regards,
  Stefano

From f140b6bce15a1705ec8258e8914e7b605ef15f6f Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Tue, 16 Nov 2010 19:18:56 +0100
Subject: [PATCH] Fix regression in ansi.test (failure on AIX 5.3).

* tests/ansi.test: Remove redundant hackish check done using a
hand-postprocessed Makefile.in.  This checs worked by setting
the `$(SHELL)' macro on the command line of make, but this is
not supported by the AIX 5.3 make implementation.

This bug has been lurking for a long time, and was activated by
commit v1.11-125-gc1f6cdb "Enable `errexit' shell flag in various
tests".  Report by Ralf Wildenhues.
---
 ChangeLog       |   11 +++++++++++
 tests/ansi.test |    6 ++----
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6f6ca10..d06ce59 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2010-11-16  Stefano Lattarini  <address@hidden>
+
+       Fix regression in ansi.test (failure on AIX 5.3).
+       * tests/ansi.test: Remove redundant hackish check done using a
+       hand-postprocessed Makefile.in.  This checs worked by setting
+       the `$(SHELL)' macro on the command line of make, but this is
+       not supported by the AIX 5.3 make implementation.
+       This bug has been lurking for a long time, and was activated by
+       commit v1.11-125-gc1f6cdb "Enable `errexit' shell flag in various
+       tests".  Report by Ralf Wildenhues.
+
 2010-06-12  Stefano Lattarini  <address@hidden>
 
        Enable `errexit' shell flag in various tests.
diff --git a/tests/ansi.test b/tests/ansi.test
index c0778c6..7795f48 100755
--- a/tests/ansi.test
+++ b/tests/ansi.test
@@ -42,13 +42,11 @@ END
 : > ansi2knr.1
 
 $ACLOCAL
+$AUTOCONF
 $AUTOMAKE
 
-$FGREP -v @SET_MAKE@ Makefile.in > Makefile.sed
-$MAKE -f Makefile.sed SHELL=$SHELL test1
-
-$AUTOCONF
 ./configure
+
 $MAKE test1
 $MAKE test2
 
-- 
1.7.1

From 1e1f2a13d9b97f3327e7ad0e98f0cc10b6dd490a Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Tue, 16 Nov 2010 20:02:54 +0100
Subject: [PATCH] Fix regression in colon{5,6}.test (failures on AIX 5.3).

* tests/colon5.test: Also substitute address@hidden@' with `$SHELL' when
post-processing the generated Makefile.in, to work around a bug
of AIX 5.3 make which doesn't allow setting the `$(SHELL)' macro
on the commend line.  Calls to `$MAKE' adjusted accordingly.
* tests/colon6.test: Likewise.

Regression introduced in commit v1.11-175-gf9fe878 "Modernize,
improve and/or extend tests `colon*.test", and reported by Ralf
Wildenhues.
---
 ChangeLog         |   12 ++++++++++++
 tests/colon5.test |    2 +-
 tests/colon6.test |    2 +-
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index eff0212..943c1f4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2010-11-16  Stefano Lattarini  <address@hidden>
+
+       Fix regression in colon{5,6}.test (failures on AIX 5.3).
+       * tests/colon5.test: Also substitute address@hidden@' with `$SHELL' when
+       post-processing the generated Makefile.in, to work around a bug
+       of AIX 5.3 make which doesn't allow setting the `$(SHELL)' macro
+       on the commend line.  Calls to `$MAKE' adjusted accordingly.
+       * tests/colon6.test: Likewise.
+       Regression introduced in commit v1.11-175-gf9fe878 "Modernize,
+       improve and/or extend tests `colon*.test", and reported by Ralf
+       Wildenhues.
+
 2010-08-08  Stefano Lattarini  <address@hidden>
 
        Modernize, improve and/or extend tests `colon*.test.
diff --git a/tests/colon5.test b/tests/colon5.test
index c53910e..9dae9c8 100755
--- a/tests/colon5.test
+++ b/tests/colon5.test
@@ -45,7 +45,7 @@ $AUTOMAKE
 grep 'Makefile:Makefile\.in' Makefile.in
 grep '^Makefile:.* \$(srcdir)/Makefile\.dep' Makefile.in
 
-sed '/@SET_MAKE@/d' <Makefile.in >Makefile.sed
+sed -e '/@SET_MAKE@/d' -e "address@hidden@!$SHELL!g" <Makefile.in >Makefile.sed
 $MAKE -f Makefile.sed SHELL=$SHELL test
 
 :
diff --git a/tests/colon6.test b/tests/colon6.test
index 4fb738e..7c620d6 100755
--- a/tests/colon6.test
+++ b/tests/colon6.test
@@ -47,7 +47,7 @@ $AUTOMAKE
 $EGREP 'Makefile:.*(demo|version)' demo/Makefile.in && Exit 1
 grep 'version\.good:.*version\.gin' demo/Makefile.in
 
-sed '/@SET_MAKE@/d' <demo/Makefile.in >Makefile.sed
+sed -e '/@SET_MAKE@/d' -e "address@hidden@!$SHELL!g" <demo/Makefile.in 
>Makefile.sed
 $MAKE -f Makefile.sed SHELL=$SHELL test
 
 :
-- 
1.7.1