[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/7] Tests defs: prefer "$curdir" over "`pwd`".
From: |
Stefano Lattarini |
Subject: |
[PATCH 2/7] Tests defs: prefer "$curdir" over "`pwd`". |
Date: |
Sun, 7 Nov 2010 16:16:53 +0100 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
* tests/defs.in: We already save the value of `pwd` in $curdir
early in the file, so there no need to recalculate it later, when
the current working directory is not changed.
---
ChangeLog | 5 +++++
tests/defs.in | 6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
From 636916637cd076286cf134ebcdb2e5dddada017f Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Fri, 5 Nov 2010 17:20:55 +0100
Subject: [PATCH 2/7] Tests defs: prefer "$curdir" over "`pwd`".
* tests/defs.in: We already save the value of `pwd` in $curdir
early in the file, so there no need to recalculate it later, when
the current working directory is not changed.
---
ChangeLog | 5 +++++
tests/defs.in | 6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 49f0bfc..0a5f849 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2010-11-06 Stefano Lattarini <address@hidden>
+ Tests defs: prefer "$curdir" over "`pwd`".
+ * tests/defs.in: We already save the value of `pwd` in $curdir
+ early in the file, so there no need to recalculate it later, when
+ the current working directory is not changed.
+
Tests defs: various reorderings, some improvements.
* tests/defs.in: Reordered various snippets of code in a clearer
way. Improved a couple of error messages, by reporting the test
diff --git a/tests/defs.in b/tests/defs.in
index 9ce76c4..700365d 100644
--- a/tests/defs.in
+++ b/tests/defs.in
@@ -105,7 +105,7 @@ old_timestamp=198309271735.59
curdir=`pwd`
# Make our wrapper scripts accessible by default.
-PATH="`pwd`$PATH_SEPARATOR$PATH"; export PATH
+PATH="$curdir$PATH_SEPARATOR$PATH"; export PATH
## -------------------------------------------------------- ##
@@ -395,10 +395,10 @@ case " $required " in
esac
# Libtool cannot cope with spaces in the build tree. Our testsuite setup
# cannot cope with spaces in the source tree name for Libtool and gettext
- # tests. Using just "`pwd`" for the check here is ok, since the further
+ # tests. Using just `$curdir' for the check here is ok, since the further
# temporary subdirectory where the test will be run is ensured not to
# contain any space.
- case $testsrcdir,`pwd` in
+ case $testsrcdir,$curdir in
*\ * | *\ *) exit 77;;
esac
ACLOCAL="$ACLOCAL -Wno-syntax -I $top_testsrcdir/m4 $extra_includes -I
$aclocaldir"
--
1.7.1
- [PATCH 0/7] Refactoring of testcases initialization code (was: Re: [PATCH 0/5] More cosmetic and consistency changes for tests/defs), Stefano Lattarini, 2010/11/07
- [PATCH 1/7] Tests defs: various reorderings, some improvements., Stefano Lattarini, 2010/11/07
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements., Ralf Wildenhues, 2010/11/10
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements., Stefano Lattarini, 2010/11/10
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements., Ralf Wildenhues, 2010/11/11
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements., Stefano Lattarini, 2010/11/11
- Re: [PATCH 1/7] Tests defs: various reorderings, some improvements., Ralf Wildenhues, 2010/11/11
[PATCH 2/7] Tests defs: prefer "$curdir" over "`pwd`".,
Stefano Lattarini <=
[PATCH 3/7] Tests defs: rename $curdir -> $testbuilddir, Stefano Lattarini, 2010/11/07
[PATCH 4/7] Tests defs: do not print message "Running test $0" anymore., Stefano Lattarini, 2010/11/07
[PATCH 5/7] Tests defs: $testsbuilddir is now AC_SUBST'ed., Stefano Lattarini, 2010/11/07
[PATCH 6/7] Tests defs: new AC_SUBST'ed variable $top_testsbuilddir., Stefano Lattarini, 2010/11/07