Re: [FYI] {master} Fix potential bug in generated tests `instpc-*.test'. (was: Re: tests updates)

[Ralf Wildenhues]

* Stefano Lattarini wrote on Fri, Nov 05, 2010 at 09:21:28PM CET:
> Nonetheless, there was still a potential bug  (introduced by the merge)
> lurking in there, which didn't manifest itself because, by sheer luck,
> the Automake parallel test driver worked around it (by exporting
> "srcdir=$(srcdir)" in the tests' environment).
> 
> After some testing, I pushed the attached patch, which should fix the bug.

Thanks.

Cheers,
Ralf

> From 0c615cdc89beb544dedc7ee665e9e68e86f3468c Mon Sep 17 00:00:00 2001
> From: Stefano Lattarini <address@hidden>
> Date: Fri, 5 Nov 2010 21:14:30 +0100
> Subject: [PATCH] Fix potential bug in generated tests `instpc-*.test'.
> 
> This bug is due to the changes introduced by the recently-merged
> "tests-init" branch.  In that branch, `tests/defs' didn't define
> anymore `$srcdir', instead defininig directly `$testsrcdir'; but
> the generated tests were using `$srcdir', hence the bug.
> Luckily, since the Automake parallel test driver automatically
> exports `srcdir' to a proper value, that prevented the bug from
> manifesting itself.
> 
> * tests/Makefile.am ($(instspc_tests)): In the generated test
> scripts, use `$testsrcdir', not `$srcdir'.