[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: More problems with `make -n' in automake-generated rules.
From: |
Ralf Wildenhues |
Subject: |
Re: More problems with `make -n' in automake-generated rules. |
Date: |
Sat, 6 Nov 2010 17:59:28 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi Stefano,
* Stefano Lattarini wrote on Sat, Nov 06, 2010 at 05:52:57PM CET:
> Hi Ralf, I've just spotted a bug in the patch ...
> > - $output_rules .= "\$(srcdir)/$headerfile:
> > \$(srcdir)/${derived}_vala.stamp\n".
> > - "address@hidden test -f \$@; then :; else \\\n".
> > - "\t rm -f \$(srcdir)/${derived}_vala.stamp; \\\n".
> > - "\t \$(am__cd) \$(srcdir) && \$(MAKE) \$(AM_MAKEFLAGS)
> > ${derived}_vala.stamp; \\\n".
> > - "\tfi\n";
> > + $output_rules .= "\$(srcdir)/$headerfile:
> > \$(srcdir)/${derived}_vala.stamp\n"
> > + . "address@hidden test -f \$@; then :; else rm -f
> > \$(srcdir)/${derived}_vala.stamp; \n"
> ... here (missing "fi"). It causes a failure in `vala2.test'.
>
> I'll install a fix later if you don't beat me (right now I'm doing other
> testing, and prefer not to be sidetracked by this issue).
That's what I get for forgetting one testsuite addition. Thanks for
tracking this down, and please push the fix, ideally together with a
new test (but better fixed without than nothing).
Cheers,
Ralf
- Re: More problems with `make -n' in automake-generated rules., (continued)
Re: More problems with `make -n' in automake-generated rules., Stefano Lattarini, 2010/11/03
Re: More problems with `make -n' in automake-generated rules., Stefano Lattarini, 2010/11/06
- Re: More problems with `make -n' in automake-generated rules.,
Ralf Wildenhues <=
Re: More problems with `make -n' in automake-generated rules., Ralf Wildenhues, 2010/11/10
[PATCH] tests/yaccdry.test ($required): Require bison. (was: Re: More problems with `make -n' in automake-generated rules.), Stefano Lattarini, 2010/11/14