Re: [PATCH] Overhauled and modularized tests in `instspc.test'.

[Stefano Lattarini]

And by the way, the patch can still be simplified by noting that
simple whitespace characters do not create problems at make-time
test generation; so I'd like to squash in the following.  OK?

Regards,
   Stefano

-*-*-*-

diff --git a/tests/gen-instspc-tests b/tests/gen-instspc-tests
index 4b9cc46..218a73b 100755
--- a/tests/gen-instspc-tests
+++ b/tests/gen-instspc-tests
@@ -51,9 +51,9 @@ count=0
 for weird_chars in \
   '!' '"' '${sh}' '${dl}' '%' '&' '${sq}' '(' ')' '*' '+' ',' '-' \
   ':' ';' '<' '=' '>' '?' '@' '[' '\' ']' '^' '`' '{' '|' '}' '~' \
-  '${bs}' '${cr}' '${ff}' '${ht}' '${lf}' '${sp}' \
+  ' ' '${bs}' '${cr}' '${ff}' '${ht}' '${lf}' \
   '@<:@' '@:>@' '@S|@' '@%:@' '@&t@' \
-  'a${sp}b' 'a${sp}${sp}b' 'a${lf}b' '...' 'a:'
+  'a b' 'a  b' 'a${lf}b' '...' 'a:'
 do
   count=`expr $count + 1`
   # Simply naming the tests using incremental numbers seems to
diff --git a/tests/instspc.sh b/tests/instspc.sh
index c018941..895c924 100644
--- a/tests/instspc.sh
+++ b/tests/instspc.sh
@@ -61,7 +61,6 @@ ff='^L'  # form feed
 ht='   ' # horizontal tab
 lf='
 '         # line feed (aka newline)
-sp=' '    # space
 
 # Some other character that might be problematic in makefiles.
 dl=\$ # dollar
@@ -74,14 +73,14 @@ sh=\# # sharp
 # `gen-instspc-tests' for more information).  Since we are at it, we
 # perform some more sanity checks.
 case $weird_chars in
-  '${bs}'|'${cr}'|'${ff}'|'${ht}'|'${lf}'|'${sp}'|'${dl}'|'${sq}'|'${sh}')
+  '${bs}'|'${cr}'|'${ff}'|'${ht}'|'${lf}'|'${dl}'|'${sq}'|'${sh}')
     eval "weird_chars=$weird_chars" || Exit 99
     if test x"$weird_chars" = x; then
       echo "$me: \"weird\" char '$weird_chars' evaluated to empty" >&2
       Exit 99
     fi
     ;;
-  'a${sp}b'|'a${sp}${sp}b'|'a${lf}b')
+  'a${lf}b')
     eval "weird_chars=$weird_chars" || Exit 99
     if test x"$weird_chars" = x"ab"; then
       echo "$me: bad expansion for \"weird\" chars '$weird_chars'" >&2