[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Work around a bug in Solaris make's file-inclusion mechanism
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] Work around a bug in Solaris make's file-inclusion mechanism. |
Date: |
Mon, 13 Sep 2010 21:31:11 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
On Monday 13 September 2010, Ralf Wildenhues wrote:
> Hi Stefano,
> > Given the information Dave provided, it seems to me that the only
> > way a leading `//' could be problematic for the automake code in
> > question is when a file path specified in a prog_SOURCES begins
> > with `//' (and this path must be put there directly and
> > explicitly by the Makefile.am author, since the content of
> > prog_SOURCES must be literal and not e.g. substituted by
> > configure).
>
> Or by some user trying to hack our dependency tracking mechanisms.
> Even if the code does not trigger in this case, the day will come
> when somebody copies that code to use it on another case where it
> may trigger. We may not be around to watch.
>
> > Ralf, are we sure we want to complicate the already complex
> > automake code to allow for such (ab)use of functionalities?
>
> Yes, we would like to treat file names consistently. Consider
> factoring out complex issues into their own well-defined functions
> to avoid needless complexity.
Agreed, let's go with correctness over simplicity. I'll try to respin
the patch (maybe not soonish, but it's not a top-priority anyway).
Thanks,
Stefano
- Re: [PATCH] Work around a bug in Solaris make's file-inclusion mechanism., Ralf Wildenhues, 2010/09/13
- Re: [PATCH] Work around a bug in Solaris make's file-inclusion mechanism.,
Stefano Lattarini <=
- [PATCH v2] Work around a bug in Solaris make's file-inclusion mechanism., Stefano Lattarini, 2010/09/15
- Re: [PATCH v2] Work around a bug in Solaris make's file-inclusion mechanism., Ralf Wildenhues, 2010/09/15
- Re: [PATCH v2] Work around a bug in Solaris make's file-inclusion mechanism., Stefano Lattarini, 2010/09/15
- Re: [PATCH v2] Work around a bug in Solaris make's file-inclusion mechanism., Stefano Lattarini, 2010/09/22
- [PATCH v3] Work around a bug in Solaris make's file-inclusion mechanism., Stefano Lattarini, 2010/09/22
- Re: [PATCH v3] Work around a bug in Solaris make's file-inclusion mechanism., Ralf Wildenhues, 2010/09/26
- Re: [PATCH v3] Work around a bug in Solaris make's file-inclusion mechanism., Stefano Lattarini, 2010/09/26
- [PATCH v3 2/?] Work around a bug in Solaris make's file-inclusion mechanism., Stefano Lattarini, 2010/09/24
- Re: [PATCH v3 2/?] Work around a bug in Solaris make's file-inclusion mechanism., Ralf Wildenhues, 2010/09/26
- Re: [PATCH v3 2/?] Work around a bug in Solaris make's file-inclusion mechanism., Stefano Lattarini, 2010/09/26