automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SIMPLE PATCH] {maint} Do not require "gzip" explicitly in tests.


From: Stefano Lattarini
Subject: [SIMPLE PATCH] {maint} Do not require "gzip" explicitly in tests.
Date: Wed, 8 Sep 2010 22:58:19 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

Hi Ralf.

Since the patch series "Fix/improve requirements declaration for test 
scripts" is starting to fall hopelessly out of sync with the state of
the master branch (and this situation will only be worsened by the
on-going refactoring of tests/defs.in in the "tests-init" branch), 
what about applying at least the attached patch to maint?  It is 
simple and uncontroversial enough IMHO (unfortunately it happened
to be the last one in the said patch series; bummer).

OK for maint?

Regards,
   Stefano
From 9a561f9664f8d14ed132ee33d6e8550ba42de7bf Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Mon, 5 Jul 2010 01:23:16 +0200
Subject: [PATCH] Do not require "gzip" explicitly in tests.

The gzip utility is simply expected to be present on any decent
target system for Automake.  So it's pointless to put it in
$required.

* tests/install2.test ($required): Do not require "gzip".
* tests/lex3.test: Likewise.
* tests/pr9.test: Likewise.

From a suggestion by Ralf Wildenhues.
---
 ChangeLog           |    9 +++++++++
 tests/install2.test |    5 +++--
 tests/lex3.test     |    2 +-
 tests/pr9.test      |    1 -
 4 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9444b66..2334c5c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,14 @@
 2010-09-08  Stefano Lattarini  <address@hidden>
 
+       Do not require "gzip" explicitly in tests.
+       The gzip utility is simply expected to be present on any decent
+       target system for Automake.  So it's pointless to put it in
+       $required.
+       * tests/install2.test ($required): Do not require "gzip".
+       * tests/lex3.test: Likewise.
+       * tests/pr9.test: Likewise.
+       From a suggestion by Ralf Wildenhues.
+
        Make some `confh*.test' tests more "semantic" (plus tweakings).
        * tests/confh.test: Run "autoconf", "configure" and "make check",
        instead of munging/grepping the generated `Makefile.in'.
diff --git a/tests/install2.test b/tests/install2.test
index d1f27fe..3cc71f5 100755
--- a/tests/install2.test
+++ b/tests/install2.test
@@ -1,5 +1,6 @@
 #! /bin/sh
-# Copyright (C) 1999, 2000, 2001, 2002, 2006  Free Software Foundation, Inc.
+# Copyright (C) 1999, 2000, 2001, 2002, 2006, 2010 Free Software
+# Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -17,8 +18,8 @@
 # Test for bug in `make dist'
 # From Pavel Roskin.
 
-required=gzip
 . ./defs || Exit 1
+
 set -e
 
 cat > configure.in << 'END'
diff --git a/tests/lex3.test b/tests/lex3.test
index 178a54f..c4120cf 100755
--- a/tests/lex3.test
+++ b/tests/lex3.test
@@ -18,7 +18,7 @@
 # Test associated with PR 19.
 # From Matthew D. Langston.
 
-required='gcc gzip flex GNUmake'
+required='gcc flex GNUmake'
 . ./defs || Exit 1
 
 # Ignore user CFLAGS.
diff --git a/tests/pr9.test b/tests/pr9.test
index 4638b52..a2e71d7 100755
--- a/tests/pr9.test
+++ b/tests/pr9.test
@@ -23,7 +23,6 @@
 # ltconfig, ltmain.sh, mdate-sh, missing, and mkinstalldirs.  In fact,
 # the entire `support/' directory is omitted.
 
-required=gzip
 . ./defs || Exit 1
 
 set -e
-- 
1.7.1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]