[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/5] Tests defs: prefer "$curdir" over "`pwd`", where possible.
From: |
Stefano Lattarini |
Subject: |
[PATCH 2/5] Tests defs: prefer "$curdir" over "`pwd`", where possible. |
Date: |
Wed, 8 Sep 2010 20:52:57 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
* tests/defs.in: We already save the value of `pwd` in $curdir
early in the file, so there no need to recalculate it later, when
the current working directory is not changed.
---
ChangeLog | 5 +++++
tests/defs.in | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
From fde4cb863c836c28999269dac438a165b8e1a4fc Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Wed, 8 Sep 2010 17:15:58 +0200
Subject: [PATCH 2/5] Tests defs: prefer "$curdir" over "`pwd`", where possible.
* tests/defs.in: We already save the value of `pwd` in $curdir
early in the file, so there no need to recalculate it later, when
the current working directory is not changed.
---
ChangeLog | 5 +++++
tests/defs.in | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 0095b80..cf4c783 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2010-09-08 Stefano Lattarini <address@hidden>
+ Tests defs: prefer "$curdir" over "`pwd`", where possible.
+ * tests/defs.in: We already save the value of `pwd` in $curdir
+ early in the file, so there no need to recalculate it later, when
+ the current working directory is not changed.
+
Tests defs: various reorderings, some improvements.
* tests/defs.in: Reordered various snippets of code in a clearer
way. Improved a couple of error messages, by reporting the test
diff --git a/tests/defs.in b/tests/defs.in
index d792484..9991741 100644
--- a/tests/defs.in
+++ b/tests/defs.in
@@ -116,7 +116,7 @@ sleep='sleep @MODIFICATION_DELAY@'
old_timestamp=198309271735.59
# Make our wrapper scripts accessible by default.
-PATH="address@hidden@$PATH"
+PATH="address@hidden@$PATH"
# Some shells forget to export modified environment variables.
# (See note about `export' in the Autoconf manual.)
export PATH
@@ -394,7 +394,7 @@ case " $required " in
# tests. Using just `$curdir' for the check here is ok, since the furter
# temporary subdirectory where the test will be run is ensured not to
# contain any space.
- case $testsrcdir,`pwd` in
+ case $testsrcdir,$curdir in
*\ * | *\ *) exit 77;;
esac
ACLOCAL="$ACLOCAL -Wno-syntax -I $top_testsrcdir/m4 $extra_includes -I
$aclocaldir"
--
1.7.1
- [PATCH 0/5] More cosmetic and consistency changes for tests/defs (both tiny and large), Stefano Lattarini, 2010/09/08
- [PATCH 1/5] Tests defs: various reorderings, some improvements., Stefano Lattarini, 2010/09/08
- [PATCH 2/5] Tests defs: prefer "$curdir" over "`pwd`", where possible.,
Stefano Lattarini <=
- [PATCH 3/5] Tests defs: rename $curdir -> $testbuilddir, Stefano Lattarini, 2010/09/08
- [PATCH 4/5] Tests defs: do not print message "Running test $0" anymore., Stefano Lattarini, 2010/09/08
- [PATCH 5/5] Tests defs: improve messages for skipped tests., Stefano Lattarini, 2010/09/08