[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: parallel-tests: avoid command-line length limit issue.
From: |
Stefano Lattarini |
Subject: |
Re: parallel-tests: avoid command-line length limit issue. |
Date: |
Tue, 7 Sep 2010 11:23:11 +0200 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
[dropping address@hidden
Hi Ralf. That was a nice fix! Just a minor nit, though...
>
> [CUT]
> parallel-tests: avoid command-line length limit issue.
>
> [CUT]
> diff --git a/lib/am/check.am b/lib/am/check.am
> index c612b22..b79201f 100644
> --- a/lib/am/check.am
> +++ b/lib/am/check.am
> @@ -236,10 +236,10 @@ check-TESTS:
> ## we rely on .PHONY to work portably.
> @test -z "$(TEST_SUITE_LOG)" || rm -f $(TEST_SUITE_LOG)
> @list='$(TEST_LOGS)'; \
> - list=`for f in $$list; do \
> - test .log = $$f || echo $$f; \
> - done | tr '\012\015' ' '`; \
> - $(MAKE) $(AM_MAKEFLAGS) $(TEST_SUITE_LOG) TEST_LOGS="$$list"
> + { echo "TEST_LOGS = \\"; \
> + for f in $$list; do test .log = $$f || echo "$$f \\"; done; \
> + } | sed '$$s/\\$$//' \
> + | $(MAKE) -f %MAKEFILE% -f - $(AM_MAKEFLAGS) $(TEST_SUITE_LOG)
This new code is by no means obvious to me (well, it is now that you have
explained and motivated it ;-). What about adding a proper comment to it?
Do you want me to (try to) do that, or will you take care of it yourself?
Thanks,
Stefano