[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is uncondition
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted. |
Date: |
Sun, 5 Sep 2010 23:02:52 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
Hi Stefano,
* Stefano Lattarini wrote on Fri, Sep 03, 2010 at 12:14:18AM CEST:
> * tests/defs.in ($srcdir): Define unconditionally to @address@hidden
> Remove code $srcdir normalization, which is now useless.
> --- a/tests/defs.in
> +++ b/tests/defs.in
> @@ -21,7 +21,7 @@
> # Tom Tromey <address@hidden>
>
> # Absolutely necessary variable(s).
> -srcdir=${srcdir-'@abs_srcdir@'}
> +srcdir='@abs_srcdir@'
Can you explain why this is not needed conditionally any more?
I mean, was there a reason we didn't already do that last time?
Thanks,
Ralf
> @@ -234,18 +234,6 @@ do
> esac
> done
>
> -
> -# Always use an absolute srcdir. Otherwise symlinks made in subdirs
> -# of the test dir just won't work.
> -case "$srcdir" in
> - [\\/]* | ?:[\\/]*)
> - ;;
> -
> - *)
> - srcdir=`CDPATH=: && cd "$srcdir" && pwd`
> - ;;
> -esac
> -
- [PATCH 0/4] {branch "tests-init"} Tests defs: renamings, tweakings and extensions in some global variables, Stefano Lattarini, 2010/09/02
- [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Stefano Lattarini, 2010/09/02
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted.,
Ralf Wildenhues <=
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Stefano Lattarini, 2010/09/05
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Ralf Wildenhues, 2010/09/06
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Stefano Lattarini, 2010/09/06
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Ralf Wildenhues, 2010/09/06
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Stefano Lattarini, 2010/09/06
- Re: [PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted., Ralf Wildenhues, 2010/09/06
Re: [PATCH 2/4] {branch "tests-init"} Tests defs: new variable $top_srcdir., Stefano Lattarini, 2010/09/02
[PATCH 3/4] {branch "tests-init"} Tests defs: remove variable $testaclocaldir., Stefano Lattarini, 2010/09/02