automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/6] Test that aclocal(s) used by the testsuite and by autoco


From: Ralf Wildenhues
Subject: Re: [PATCH 1/6] Test that aclocal(s) used by the testsuite and by autoconf match.
Date: Sat, 21 Aug 2010 09:37:33 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

Hi Stefano,

you don't make it easy to catch up with you!  :-O

* Stefano Lattarini wrote on Thu, Aug 19, 2010 at 02:54:52PM CEST:
> * tests/remake0.test: New test.
> * tests/Makefile.am (TESTS): Updated.

OK with ...

> --- /dev/null
> +++ b/tests/remake0.test
> @@ -0,0 +1,38 @@

> +# Make sure the autoconf used by $ACLOCAL and the autoconf used by the

... either  s/the$//  here, or

> +# Automake's testsuite match.  This is mostly a sanity check for the

s/'s//  here.

> +# Automake's testsuite, and its failure is an indication that the others

s/'s//   s/ and / /   s/others/other/

> +# tests (especailly other `remake*.test' tests) might experience spurious

s/especailly/especially/

> +# problems.
> +
> +. ./defs || Exit 1
> +
> +set -e
> +
> +: > Makefile.am
> +
> +$ACLOCAL 2>stderr || { cat stderr >&2; Exit 1; }
> +cat stderr >&2
> +grep -i 'warning.*generated for autoconf' stderr && Exit 1
> +grep -i 'another version of autoconf' stderr && Exit 1

Is it possible to have a warning here already?  How?
If not, please add a short comment before these two lines
that this is not expected to happen.

> +$AUTOCONF 2>stderr || { cat stderr >&2; Exit 1; }
> +cat stderr >&2
> +grep -i 'warning.*generated for autoconf' stderr && Exit 1
> +grep -i 'another version of autoconf' stderr && Exit 1

I can see that a warning might happen here.

Thanks!
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]