automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.


From: Stefano Lattarini
Subject: Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.
Date: Sun, 8 Aug 2010 12:53:21 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:09:52PM CEST:
> > I squashed the following into the first patch:
> > 
> > It's OK for you?
> 
> Sure.
> 
> > > > (BTW, if my understanding is correct, this would make a nice
> > > > addition to HACKING, too).
> > > 
> > > Yep.
> > 
> > Attached is a follow-up patch that does that.  Comments and
> > criticism are welcome.
> 
> OK with typos fixed.
> 
> > P.S. I'll fix the dates in the ChangeLog entried before pushing.
> 
> Fine with me.  If you have all your patches in branches
Yes, a branch for every patch (series).
> or otherwise ordered, you can also just wait until I'm done
> reviewing and commit or merge them in your preferred order.  
> Whatever seems easier for you.
I should have no problem with my workflow; git is very flexible.
But thanks for your concerns.

> Also, regenerating the tree with Autoconf 2.67 and committing that
> separately is preapproved for maint.
Couldn't this cause problems when later merging to master?  If yes, 
how would those be better solved?

> 
> Thanks,
> Ralf
> 
> > Subject: [PATCH] Bootstrap: updated HACKING entry.
> > 
> > * HACKING ("Working with git"): Tell how to override the autoconf
> 
> I think  s/Tell/Explain/  is the right term.
Yes. Better.
> 
> > and autom4te used by the bootstrap process.
> 
> s/used/programs &/  ?
Better.

> 
> > --- a/HACKING
> > +++ b/HACKING
> > @@ -96,7 +96,12 @@
> > 
> >    tree, so the resulting files (aclocal.m4 and Makefile.in)
> >    should be the same as you would get if you install this
> >    version of automake and use it to generate those files.  Be
> >    sure to have the
> > 
> > -  latest stable version of Autoconf installed.
> > +  latest stable version of Autoconf installed.  If such version
> > is +  not installed as the default "autoconf" command, you'll
> > have to
> 
> I think more common would be
>   s/the default "autoconf" command/"autoconf"/
>   s/you'll have to//
Yes, less verbosity is better.

> > +  pass it explicitly (along with the accompanying "autom4te")
> > when +  calling `bootstrap' and `configure'.  For example:
> > +    $ AUTOCONF=autoconf2.65 AUTOM4TE=autom4te2.65 ./boostrap
> 
> s/boo/&t/
Oops. Fixed.

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]