[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Tests: remove useless repetitions of `foreign' automake opti
|
From: |
Ralf Wildenhues |
|
Subject: |
Re: [PATCH] Tests: remove useless repetitions of `foreign' automake option. |
|
Date: |
Sat, 26 Jun 2010 12:34:17 +0200 |
|
User-agent: |
Mutt/1.5.20 (2010-04-22) |
Hi Stefano,
* Stefano Lattarini wrote on Fri, Jun 25, 2010 at 05:22:19PM CEST:
> A minor cleanup patch for the testsuite. Should cause no semantic
> change whatsoever.
Yes, but ...
> Tests: remove useless repetitions of `foreign' automake option.
>
> * multlib.test (configure.in): Remove useless use of `foreign'
> option in AM_INIT_AUTOMAKE (the `--foreign' option is already
> in $AUTOMAKE by default, so no point in repeating it).
... except maybe for documentation purposes. Are any of the tests
truly for foreign style packages only, or is that always just used
in order to save on generating the GNU-specific files?
If the latter, then the patch is fine with me.
Thanks,
Ralf
> * subobj10.test: Likewise.
> * subobj9.test: Likewise.
> * lex3.test (Makefile.am): Similarly, remove useless use of
> `foreign' option in AUTOMAKE_OPTIONS.
> * lex5.test: Likewise.
> * pr279.test: Likewise.
> * pr279-2.test: Likewise.
> * specflg3.test: Likewise.
> * target-cflags.test: Likewise.