[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Bugfix w.r.t. $(AM_LFLAGS)/$(LFLAGS) and $(AM_YFLAGS)/$(
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH 0/2] Bugfix w.r.t. $(AM_LFLAGS)/$(LFLAGS) and $(AM_YFLAGS)/$(YFLAGS) precedence. |
Date: |
Tue, 22 Jun 2010 13:15:04 +0200 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.4; i686; ; ) |
At Monday 21 June 2010, Ralf Wildenhues wrote:
> Hi Stefano,
> I'm falling more and more behind on patches, it seems.
In this last period, it seems quite the opposite to me :-)
Thanks for your work!
I've just a minor nit about the follow-up patch...
> Ensure generated C files contain a declaration, to please
> compilers.
This is good, and I should have thought about it in the first
place. On the other hand...
> Prefer `make -e' over `make VAR=VAL', to please
> maintainer-check.
... are we sure we want to relax the tests just to please maintainer-check?
After all, those tests were working correctly with both GNU and BSD make,
and (mostly) with Solaris and Heirloom make (with failures due to those
make implementations bypassing the Automake-generated ".y => .c => .o"
rule chain in favor of their own ".y => .o" built-in rule, but that's
another story).
I think it's time to make `maintainer-check' more configurable and
whitelist-friendly. And there's no need to remain anchored to grep and
sed: since we can assume that perl is available, we can as well use all
its power...
Maybe I can come up with a tentative/proof-of-concept patch along
this line in a few days. But this is an argument for another thread,
obviously.
Regards,
Stefano