[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Minor improvements in bootstrap script.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] Minor improvements in bootstrap script. |
Date: |
Thu, 10 Jun 2010 11:13:00 +0200 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.4; i686; ; ) |
At Thursday 10 June 2010, Eric Blake wrote:
> On 06/09/2010 05:01 PM, Stefano Lattarini wrote:
> > * bootstrap: Do not create a temporary file to find the PATH
> > separator. Consistently use two-spaces indentation. Also,
> > cosmetic improvement to comments, and bumped copyright years.
> >
> > -# Find the path separator
> > -echo "#! /bin/sh" >boot$$.sh
> > -echo "exit 0" >>boot$$.sh
> > -chmod +x boot$$.sh
> > -if (PATH="/nonexistent;."; boot$$.sh) >/dev/null 2>&1; then
> > +# Find the path separator.
> > +if (PATH="/bin;/nonexistent"; export PATH; sh -c :) >/dev/null
> > 2>&1; then
>
> Will that always work on mingw, where you are not guaranteed the
> existence of /bin/sh?
Honestly, I dind't think that there were systems missing /bin/sh which
could be targets for automake :-(
Anyway, the old bootstrap script too assumed existence of /bin/sh,
since the temporary script `boot$$.sh' contained the shebang line
"#! /bin/sh". Right?
> Then again, mingw is one of the platforms where you want the
> path separator to be detected as ; rather than :.
True; thus the script still works correctly, even if just by chance.
Regards,
Stefano
- [PATCH] Minor improvements in bootstrap script., Stefano Lattarini, 2010/06/09
- Re: [PATCH] Minor improvements in bootstrap script., Eric Blake, 2010/06/09
- Re: [PATCH] Minor improvements in bootstrap script.,
Stefano Lattarini <=
- Re: [PATCH] Minor improvements in bootstrap script., Eric Blake, 2010/06/10
- Re: [PATCH] Minor improvements in bootstrap script., Stefano Lattarini, 2010/06/10
- Re: [PATCH] Minor improvements in bootstrap script., Ralf Wildenhues, 2010/06/10
- Re: [PATCH] Minor improvements in bootstrap script., Stefano Lattarini, 2010/06/10
- Re: [PATCH] Minor improvements in bootstrap script., Ralf Wildenhues, 2010/06/11
- Re: [PATCH] Minor improvements in bootstrap script., Stefano Lattarini, 2010/06/11