[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Avoid another use of `chmod -R'.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 1/2] Avoid another use of `chmod -R'. |
Date: |
Wed, 31 Mar 2010 21:27:48 +0200 |
User-agent: |
Mutt/1.5.20 (2009-10-28) |
* Stefano Lattarini wrote on Tue, Mar 30, 2010 at 09:50:52PM CEST:
> At Tuesday 30 March 2010, Ralf Wildenhues wrote:
> > I'm not sure I understand. We are not putting any symlinks into
> > $(distdir), why would this be needed?
> First, mostly for consistency with other cleanup rules (those in
> `tests/defs.in', `tests/Makefile.am' and `lib/am/distdir.am'),
But all of those rules are about directories in which we may put
symlinks.
> and
> second, to cater for the (admittedly very unlikely) case that a
> dist-hook will be added that puts a symlink in $(distdir), or that a
> bug will be introduced that ends up putting a symlink in $(distdir)
> somehow.
I wouldn't want to hide a bug preemptively, if that means it won't show
up here but only with user packages.
> > In order for symlinks to end up in $(distdir), you have to have a
> > dist-hook or similar rule, because normal distributed symlinks in
> > the source tree will be expanded as regular files in $(distdir).
> I must admit that I forgot the existence this "symlink-resolving"
> feature...
>
> By the way, is it tested in the testsuite? I couldn't find anything
> relevant by grepping the test scripts.
A testsuite addition that covers this would be welcome. Be sure to not
fail if the system doesn't support symlinks (MinGW will emulate ln -s
with cp -p).
Thanks,
Ralf
[PATCH 2/2] Avoid an unportable use of `$status' shell variable., Stefano Lattarini, 2010/03/30
Re: A couple of patches w.r.t. the target `path-check', Ralf Wildenhues, 2010/03/30