automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Automake support for ObjC++


From: Peter Breitenlohner
Subject: Re: [PATCH] Automake support for ObjC++
Date: Mon, 5 Oct 2009 15:02:08 +0200 (CEST)
User-agent: Alpine 2.00 (LNX 1167 2008-08-23)

On Tue, 15 Sep 2009, Ralf Wildenhues wrote:

Would you be so nice as to respin and simplify the patch under the
assumption that AC_PROG_OBJCXX exists?  I think it should be sufficient
to just require new enough Autoconf for this to work, that way we can
avoid all the duplication and so on.  This patch is targets 1.12 rather
than 1.11.1 anyway.  Maybe it can even omit the objcxx.m4 file
completely?

Hi Ralf,

attached is a new version of the patch. As I said earlier, I think we need
the m4/objcxx.m4 file in order to define AC_PROG_OBJCXX & Co.  The
definitions are exactly as in Autoconf-git, thus once Autoconf-2.65 is
released and can be required as prerequisite that file can be dropped.
At the same time the documentation for AC_PROG_OBJCXX in the manual should
go away and the reference to AC_PROG_OBJCXX changed accordingly -- unless
you prefer to do that right now.

I hope that Autoconf-2.65 will come before Automake-1.12 is ready.

I have just tested the patch with both Autoconf-2.64 (objcxx.m4 is required)
and Autoconf-2.64.56-dfc96 (git as of today, objcxx.m4 is not required).
The obcjxx tests pass but there are some mysterious failures (plus some
others that are caused locally and are understood):
for 2.64: aclocal9, acloca10, acloca14, nodef, python11
for 2.64.56-dfc96: aclocal9, acloca10, acloca18, missing4, nodef, python11
The tests were done on a pretty fast machine, my suspicion is that a sleep
might be required in some of these tests.

The other thing I'd like to see either in this patch or in a followup
one is your play-1.1 test rewritten as an Automake testsuite addition,
so that we have one full build test (including distcheck).  (I can do
that if you don't want to.)

Here I am somewhat unsure what exactly needs to be done for a testsuite
case.  If that is easy to explain I'll do it, otherwise I should better
leave it to you (and please feel free to add/modify copyright notices as
apropriate).

In any case, that maybe should be based on a newer version play-1.2 that
also includes a libtool library.

Regards
Peter Breitenlohner <address@hidden>

Attachment: 0001-2009-10-05-Support-for-Objective-C.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]