[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AM_SILENT_RULES doesn't silence texinfo rules

From: Ralf Wildenhues
Subject: Re: AM_SILENT_RULES doesn't silence texinfo rules
Date: Tue, 22 Sep 2009 22:42:23 +0200
User-agent: Mutt/1.5.20 (2009-08-09)

Hello Jack,

* Jack Kelly wrote on Tue, Sep 22, 2009 at 04:33:27AM CEST:
> (+ automake-patches)

(- bug-automake)

> Disclaimer has finally been processed. I suspect it will need
> additional tests (and perhaps a NEWS entry?),

Yes to both.  Thanks.

> but I wanted some eyes on the style before I got in too deep.

> Let me know if the inline patch gets mangled; if so, I'll start
> sending them as attachments.

Yes, it got mangled, please resend, I prefer review (even on style only)
when I can easily apply a patch.  For one, it makes it easy to inspect
the generated changes in the Automake source tree's files.

> >From ae772ea28436cb0c49a423b541d6b51f3e907cc9 Mon Sep 17 00:00:00 2001
> From: Jack Kelly <address@hidden>
> Date: Tue, 22 Sep 2009 12:24:04 +1000
> Subject: [PATCH] Add silent rules support for dvips, makeinfo,
> makeinfo --html, texi2dvi and texi2pdf.

Can we compress the summary line somewhat, so it fits a line?  E.g.,
  Add silent rules support for texinfo outputs.

> diff --git a/ChangeLog b/ChangeLog

It's easier to merge if you just keep the ChangeLog as part of the git
commit message.  I usually merge it into the ChangeLog file when
committing.  But it's not a big problem either way.

> +       * (define_verbose_texinfo): define several new verbose

Very minor nit: Capizalize sentences (after the colons); several

> +       tagvars and verbose vars.
> +       * (define_verbose_tagvar): increase spacing to 12 to
> +       accommodate MAKEINFOHTML.

Ugh, that's very ugly, because it will make it very difficult to align
the target name with the abbreviation used for the command, when the
build is rushing by.  I found 6 to be close to the maximum tolerable
length.  Can we either agree to create unaligned output, or abbreviate

> +       * (handle_texinfo): additional substitution for
> +       quieting dvips.
> +       * (output_texinfo_build_rules): additional
> +       substitution for quieting texi2dvi and texi2pdf.
> +       * lib/am/ Add silencing to makeinfo, makeinfo --html,
> +       texi2dvi and texi2pdf rules.
> +       * lib/am/ Add silencing to rule.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]