[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Automake support for ObjC++

From: Ralf Wildenhues
Subject: Re: [PATCH] Automake support for ObjC++
Date: Tue, 15 Sep 2009 07:19:52 +0200
User-agent: Mutt/1.5.20 (2009-08-09)

Hello Peter, and sorry for the delay.

* Peter Breitenlohner wrote on Tue, Jul 28, 2009 at 05:18:11PM CEST:
> now that autoconf-2.64 is released, here a revised version of the patch I
> sent you last week.


> This new version requires autoconf-2.64 (otherwise aclocal fails) and
> defines AM_PROG_OBJCXX.  A hook for AC_PROG_OBJCXX, eventually to be defined
> by Autoconf, is already in place.

Would you be so nice as to respin and simplify the patch under the
assumption that AC_PROG_OBJCXX exists?  I think it should be sufficient
to just require new enough Autoconf for this to work, that way we can
avoid all the duplication and so on.  This patch is targets 1.12 rather
than 1.11.1 anyway.  Maybe it can even omit the objcxx.m4 file

The other thing I'd like to see either in this patch or in a followup
one is your play-1.1 test rewritten as an Automake testsuite addition,
so that we have one full build test (including distcheck).  (I can do
that if you don't want to.)

(I think a similar note applies to the part of play-1.0 and
the Autoconf testsuite.  If you have any issues with this, or don't want
to do the work, ping me and I'll look into it.)

Otherwise, this patch seems to be in pretty good shape.


> From 8b198f23a2fc30cd4405a3594cc73a3e0ae3e3ba Mon Sep 17 00:00:00 2001
> From: Peter Breitenlohner <address@hidden>
> Date: Tue, 28 Jul 2009 15:12:42 +0200
> Subject: [PATCH] Support for Objective C++
> * m4/objcxx.m4: New Autoconf macros for Objective C++ language.
> * m4/ Adjust.
> * Require Autoconf 2.64 or better.
> * Register new language.
> (lang_objcxx_rewrite): New subroutine.
> (resolve_linker): Add OBJCXXLINK.
> (%_am_macro_for_cond): Add am__fastdepOBJCXX and AM_PROG_OBJCXX.
> * (%-ac_macro_for_var): Add OBJCXX and OBJCXXFLAGS.
> * m4/depend.m4 (_AM_DEPENDENCIES): Add OBJCXX.
> * m4/init.m4 (AM_INIT_AUTOMAKE): Add AC_PROG_OBJCXX hook.
> * tests/ext.test, tests/nodep2.test: Adjust.
> * tests/objcxx.test, tests.objcxx2.test: New tests.
> * tests/ Adjust.
> * doc/automake.texi (Objective C++ Support): New node.
> (Public Macros): Documnet AM_PROG_OBCJXX, OBJCXX, and OBJCXXFLAGS.
> (How the Linker is Chosen, Support for Other Languages): Adjust.
> * NEWS: Announce and require Autoconf 2.64 or better.
> Signed-off-by: Peter Breitenlohner <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]