Re: [PATCH 1/3] Vala: Fix build when using per-target VALAFLAGS

[Jürg Billeter]

Hi Ralf,

On Sun, 2009-05-17 at 09:41 +0200, Ralf Wildenhues wrote:
> * Jürg Billeter wrote on Fri, May 15, 2009 at 03:50:55PM CEST:
> > This does not yet implement full per-target support for VALAFLAGS,
> > however, this change at least fixes building when there is only one
> > target per source file, which is the most common situation.
> 
> When testing vala5.test with this, you get several rules including
> commands for baz.c in src/Makefile.  This will cause failures for
> non-GNU make, and thus needs to be fixed.
> 
> Also, this change now would make
>   bin_PROGRAMS = foo bar
>   foo_SOURCES = foo.vala
>   bar_SOURCES = foo.vala
>   bar_VALAFLAGS = -D bar
> 
> a possibly silently broken build, IIUC.  That deserves at least a
> comment in the manual; see the suggestion below.  I haven't thought
> about a consistency check in automake.in; fixing the issue would be
> effort spent better.

Yes, at least a comment in the manual certainly makes sense.

> Please note that I'm really close to finishing 1.11, and considering
> to postpone this change unless there is an easy way out.

I expect per-target VALAFLAGS to be relatively common as VALAFLAGS will
be used for all libraries. While using the same Vala source file in
multiple targets might be useful in some occasions, I'd expect it to be
less used than per-target VALAFLAGS. In my opinion, the Vala support in
automake 1.11 would be a lot more useful with the patchset applied.

Unfortunately, I don't have an idea right now how to easily guard
against the issue in automake.in except maybe using something like a
global array of processed .vala source files.

Thanks,
Jürg