automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] Simple typographical and grammar errors in automake.texi


From: Ralf Wildenhues
Subject: Re: [PATCH 3/3] Simple typographical and grammar errors in automake.texi.
Date: Wed, 3 Dec 2008 21:25:37 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

Hi William,

* William Pursell wrote on Mon, Dec 01, 2008 at 10:06:32PM CET:
> Fix object/article consistency (eg "an flag" becomes "a flag"),
> correct minor punctuation errors, etc.

Thanks!  Pushed with a couple of minor changes, as below.

> @@ -7839,7 +7839,7 @@ suppress the base name step.  For example:
>  nobase_include_HEADERS = stdio.h sys/types.h
>  @end example
>
> -Will install @file{stdio.h} in @samp{$(includedir)} and @file{types.h}
> +will install @file{stdio.h} in @samp{$(includedir)} and @file{types.h}
>  in @samp{$(includedir)/sys}.

I added a @noindent here.  More generally, there are probably several
@example's in the manual where the following text belongs right to it,
but there is no @noindent keeping them together, which looks a bit ugly
in the info output.

> -Note that Automake does not make any difference between rules with
> +Note that Automake does not make any distinction between rules with
>  commands and rules that only specify dependencies.

"No distinction without a difference!"  :-)
(good phrase to memorize the difference between the two words)

FWIW, I squashed in this change to avoid an underfull hbox:

@@ -8927,7 +8927,7 @@ suffixes in the @code{SUFFIXES} variable @strong{before} y
 implicit rule.
 
 For instance, the following definition prevents Automake from misinterpreting
address@hidden:} as an attempt to transform @file{.idlC} files into
+the @samp{.idlC.cpp:} rule as an attempt to transform @file{.idlC} files into
 @file{.cpp} files.
 
 @example

> @@ -9923,15 +9923,15 @@ happen.  CVS's timestamp handling can also let you 
> think an
>  out-of-date file is up-to-date.
>
>  For instance, suppose a developer has modified @file{Makefile.am} and
> -has rebuilt @file{Makefile.in}.  He then decide to do a last-minute
> +has rebuilt @file{Makefile.in}.  He then decides to do a last-minute
>  change to @file{Makefile.am} right before checking in both files
>  (without rebuilding @file{Makefile.in} to account for the change).
>
> -This last change to @file{Makefile.am} make the copy of
> +This last change to @file{Makefile.am} makes the copy of
>  @file{Makefile.in} out-of-date.  Since CVS processes files
> -alphabetically, when another developer @samp{cvs update} his or her
> +alphabetically, when another developer @samp{cvs update}s his or her

I happen to dislike quoted text with unquoted postfixes a bit; maybe
this should be reformulated as
  when another developer uses @samp{cvs update} to update his or her
  tree

Hmm.  Or maybe not; dunno.

>  tree, @file{Makefile.in} will happen to be newer than
> address@hidden  This other developer will not see
> address@hidden  This other developer will not see that
>  @file{Makefile.in} is out-of-date.


> @@ -10013,13 +10013,13 @@ the build continue is one of the arguments of the
>  @cindex @code{AM_MAINTAINER_MODE}, purpose
>  @acindex AM_MAINTAINER_MODE
>
> address@hidden allows to choose whether the so called
> address@hidden allows you to choose whether the so called
>  "rebuild rules" should be enabled or disabled.  With
>  @code{AM_MAINTAINER_MODE([enable])}, they are enabled by default,
>  otherwise they are disabled by default.  In the latter case, if
>  you have @code{AM_MAINTAINER_MODE} in @file{configure.ac}, and run
>  @samp{./configure && make}, then @command{make} will *never* attempt to
> -rebuilt @file{configure}, @file{Makefile.in}s, Lex or Yacc outputs, etc.
> +rebuild @file{configure}, @file{Makefile.in}s, Lex or Yacc outputs, etc.

This could be: @file{Makefile.in} files

>  I.e., this disables build rules for files that are usually distributed
>  and that users should normally not have to update.

> @@ -11067,7 +11067,7 @@ The @code{AM_PATH_PYTHON} macro uses similar commands 
> to define
>
>  Of course not all tools are as advanced as Python regarding that
>  substitution of @var{prefix}.  So another strategy is to figure the
> -part of the of the installation directory that must be preserved.  For
> +part of the installation directory that must be preserved.  For

Oh!  Vim is good at detecting doubled words like `the the', but it
doesn't detect doubled pairs yet.  That should be fixed.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]