automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: magic variables for included fragments


From: Ralf Wildenhues
Subject: Re: magic variables for included fragments
Date: Sat, 18 Oct 2008 10:11:10 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

* Ralf Wildenhues wrote on Sun, Oct 12, 2008 at 10:50:11PM CEST:
> [ moving to automake-patches; this is
> <http://thread.gmane.org/gmane.comp.sysutils.automake.general/9824> ]

>     Recursive `include' and helper macros.
[...]

(I'd rather not apply this without some feedback; thanks!)

But I'm applying the patch below (to master only) in order to diagnose a
potential bug I've found while writing referenced patch.  I don't think
it hits except in erroneous setups; otherwise, we can still fix it then.

Cheers,
Ralf

2008-10-18  Ralf Wildenhues  <address@hidden>

        Diagnose unsupported uses of `backname' helper function.
        * automake.in (backname): Error out if the path points outside
        the directory it started in.

diff --git a/automake.in b/automake.in
index 4e53484..335fe13 100755
--- a/automake.in
+++ b/automake.in
@@ -1053,7 +1053,8 @@ sub backname ($)
        next if $_ eq '.' || $_ eq '';
        if ($_ eq '..')
        {
-           pop @res;
+           pop @res
+             or prog_error ("trying to reverse path `$file' pointing outside 
tree");
        }
        else
        {




reply via email to

[Prev in Thread] Current Thread [Next in Thread]