[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Ralf Wildenhues
Subject: Re: AC_AUTOCONF_VERSION quoting
Date: Thu, 10 Apr 2008 22:43:23 +0200
User-agent: Mutt/1.5.17+20080114 (2008-01-14)

Hi Eric,

* Eric Blake wrote on Thu, Apr 10, 2008 at 05:59:13PM CEST:
> Automake should set a good example of proper macro quoting.  Expanding 
> AC_AUTOCONF_VERSION is dangerous, since snapshot versions of autoconf include 
> letters in the version string, which in turn could expand as inadvertent 
> macros.  Is this okay to apply, as well as cherry-pick back to branch-1-10?

Yep.  FWIW, over here the patch is mangled in a way such that both
git am and git apply reject it, so I didn't test it.

> Meanwhile, now that Autoconf 2.62 is released, is it time to regenerate all 
> the 
> generated files in the automake repository with 2.62 rather than an autoconf 
> snapshot?

Yep, please do this right alongside with the patch (no need to mention
the generated files in the ChangeLog entry).

Thank you,

> Subject: [PATCH] AC_AUTOCONF_VERSION can inadvertently expand to a macro name.
> m4 quoting.
> * (write_aclocal): Likewise.
> * tests/missing6.test: New test.
> * tests/ (TESTS): Run it.
> * tests/missing4.test: Adjust.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]