Re: [PATCH] Don't create world-writable files.

[Benoit Sigoure]

On Nov 11, 2007, at 2:31 PM, Ralf Wildenhues wrote:

> Hi Benoit,
>
> * Benoit Sigoure wrote on Sat, Nov 10, 2007 at 11:10:46PM CET:
> >         There is one last occurrence in `distdir' but it seems to be there
> >         to work around buggy tar implementations.
> >         * Makefile.am (path-check): Here.
> >         * lib/am/distdir.am (distcheck): Here.
> >         * tests/defs.in (trap setup): Here.
>
> Thank you.  The patch is obviously an improvement.  However, maybe we
> can even go further, and eliminate all instances.  Have you checked  
> how
> relevant this `tar' implementation still is?  If it isn't, them I'm
> inclined to just note this in NEWS (please also note your fix in NEWS,
> it is important!) that we don't support it any more.  Then, please  
> check
> again that we haven't missed any occurrence, and apply to master.

The comment simply reads:
`make directories writable by everybody, because some
brain-dead tar implementations change ownership and permissions of
a directory before extracting the files, thus becoming unable to
extract them'

I don't know which implementation of tar has this ugly wart (hello Mr  
Solaris, you there?  Just kidding heh :D) so I chose a more  
conservative approach.  This could well be a bug in a widespread  
implementation of tar or whatever.

> If you don't have time, let me know and I'll finish this up.  Anyway
> I'll pull this into branch-1-10.

This comment was introduced by Alexandre Oliva (http:// 
git.savannah.gnu.org/gitweb/?p=automake.git;a=commit;h=2d5c3ab) in  
1999 (:D), maybe he remembers which implementation of tar was impacted.

Cheers,

--
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory

PGP.sig
Description: This is a digitally signed message part