[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
IFS in install-sh and mkinstalldirs
From: |
Ralf Wildenhues |
Subject: |
IFS in install-sh and mkinstalldirs |
Date: |
Tue, 2 May 2006 21:56:49 +0200 |
User-agent: |
Mutt/1.5.11+cvs20060403 |
Posix allows shells to have IFS unset at startup (and some older Debian
ash versions -- IIRC distributed with RedHat -- do this); unset IFS is
fine since the shell is required to behave as if it were set to space
tab newline. However, set but empty IFS is different: it disables field
splitting: oIFS=$IFS; ...; IFS=$oIFS.
The patch below fixes this for install-sh and mkinstalldirs. OK?
Cheers,
Ralf
* lib/install-sh: Initialize IFS, so field splitting isn't
turned off later.
* lib/mkinstalldirs: Likewise.
Index: lib/install-sh
===================================================================
RCS file: /cvs/automake/automake/lib/install-sh,v
retrieving revision 1.32
diff -u -r1.32 install-sh
--- lib/install-sh 25 Apr 2006 20:13:37 -0000 1.32
+++ lib/install-sh 2 May 2006 19:47:15 -0000
@@ -1,7 +1,7 @@
#!/bin/sh
# install - install a program, script, or datafile
-scriptversion=2006-04-25.22
+scriptversion=2006-05-02.22
# This originates from X11R5 (mit/util/scripts/install.sh), which was
# later released in X11R6 (xc/config/util/install.sh) with the
@@ -42,6 +42,10 @@
# from scratch. It can only install one file at a time, a restriction
# shared with many OS's install programs.
+nl='
+'
+IFS=" "" $nl"
+
# set DOITPROG to echo to test this script
# Don't use :- since 4.3BSD and earlier shells don't like it.
Index: lib/mkinstalldirs
===================================================================
RCS file: /cvs/automake/automake/lib/mkinstalldirs,v
retrieving revision 1.19
diff -u -r1.19 mkinstalldirs
--- lib/mkinstalldirs 29 Jun 2005 21:08:19 -0000 1.19
+++ lib/mkinstalldirs 2 May 2006 19:47:15 -0000
@@ -1,7 +1,7 @@
#! /bin/sh
# mkinstalldirs --- make directory hierarchy
-scriptversion=2005-06-29.22
+scriptversion=2006-05-02.22
# Original author: Noah Friedman <address@hidden>
# Created: 1993-05-16
@@ -11,6 +11,9 @@
# bugs to <address@hidden> or send patches to
# <address@hidden>.
+nl='
+'
+IFS=" "" $nl"
errstatus=0
dirmode=
- IFS in install-sh and mkinstalldirs,
Ralf Wildenhues <=