Re: automake/483: "missing" doesn't handle "--output" for missing makeinfo

[Ralf Wildenhues]

http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=automake&pr=483

Hi Dennis,

Sorry for the long delay, and thanks for the bug report.

Looking at the `missing' script, there are a couple more issues:
- the sed scripts for matching `-o' and `--output' aren't all the
  same; furthermore, they are less strict than they could be: we
  can know for sure both flags will be preceded by a space, and
  there will be exactly one space or equal sign between `--output'
  and its argument (all due to how we echo the args before);
- autom4te isn't documented in --help output.

So then I got adventurous and wrote another one of those testsuite
tests that are supposed to entertain the reader.  ;-)
(I'll leave it as an exercise to find out why I removed usage of `['
from `missing'.)

OK to apply both attached patches?

Cheers,
Ralf

        * lib/missing (sed_minuso, sed_output): New variables.
        (autom4te, help2man, makeinfo): Use them.  Unifies detection of
        `-o FILE', `--output FILE', `--output=FILE', stricter regex.
        Fixes `missing' to detect `--output' for help2man (PR 483).
        Report by Dennis J. Linse <address@hidden>.
        (autom4te): Document in `missing --help'.
        * THANKS: Update.

        * lib/missing: Remove superfluous quotes.  Replace all uses of
        `[' by `test', for consistency, and for..
        * tests/missing4.test: ..this new test.
        * tests/Makefile.am: Update.

missing-output.diff
Description: Text document

missing-test-quotes.diff
Description: Text document