[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: allow (sub)packages to share files in subpackages

From: Alexandre Duret-Lutz
Subject: Re: allow (sub)packages to share files in subpackages
Date: Sat, 18 Mar 2006 08:37:57 +0100
User-agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux)

>>> "RW" == Ralf Wildenhues <address@hidden> writes:


 RW> [3] The $(MAKE) invocation for the subpackage `distdir' is not
 RW> portable to all `make' implementation (as not all allow to override
 RW> set macros from the command line); this requirement does not change
 RW> with the patch.

It looks portable to me (as long as you don't expect your
assignment to hold for the submakes of the one being launched,
of course, but that's not needed here).

 RW> Allow package trees (packages with subpackages) to share
 RW> common distributed auxiliary files (and directories) that
 RW> reside within a subpackage.

 RW> * lib/am/ (distdir %?TOPDIR_P%): Do not fail if
 RW> `$(distdir)' already exists.
 RW> (%?SUBDIRS%): Set `am__remove_distdir' to `:' to prevent
 RW> removal of subpackage trees for distribution.
 RW> * tests/subpkg3.test: New test.
 RW> * tests/ Updated.

"Update." :)


 RW> --- lib/am/      3 Oct 2005 20:48:59 -0000       1.62
 RW> +++ lib/am/      12 Jan 2006 20:21:07 -0000
 RW> @@ -50,7 +50,7 @@
 RW> ##
 RW> if %?TOPDIR_P%
 RW> $(am__remove_distdir)
 RW> -  mkdir $(distdir)
 RW> +  test -d $(distdir) || mkdir $(distdir)
 RW> endif %?TOPDIR_P%
 RW> ##
 RW> ##
 RW> @@ -175,6 +175,7 @@
 RW> top_distdir="$$top_distdir" \
 RW> distdir="$$distdir/$$subdir" \
 RW> +          am__remove_distdir=: \
 RW> distdir) \

Somme comment along the lines of 
## Disable am__remove_distdir so that sub-package do not clear a
## directory we have already cleared and might even have populated
## populated (e.g. shared AUX dir in the sub-package.)
maybe ?  At least it sure would help my bad memories.

Otherwise the patch looks fine to me, please install!

+cat >subpkg/foobar <<'END'
+cat >subpkg/ <<'END'

It doesn't matter to me here, but those could be echos if you care
for speed (I think to remember you do).
Alexandre Duret-Lutz

Shared books are happy books.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]