Re: FYI: allow serial garbage and more #serial doc

[Alexandre Duret-Lutz]

>>> "Jim" == Jim Meyering <address@hidden> writes:

 >> # Match a serial number
 >> -my $serial_line_rx = '^#\s*serial\s*(.*?)\s*$';
 >> +my $serial_line_rx = '^#\s*serial\s*(\S*)';
 >> my $serial_number_rx = '^\d+(?:\.\d+)*$';

 Jim> but I have to ask anyhow: Did you intend to allow input like
 Jim> `#serial2' with no white space?  

Oops, no!  Thanks for catching this.  (Only the first \s* after
`#' was deliberate; some people don't use any space here.)

I have installed the following patch.

 Jim> I know about the saying `be liberal in what you
 Jim> accept...', but I also noticed that the code would seem to
 Jim> warn about trailing white space (a good thing, IMHO).

Are you sure?  I can't see this.  (But I have not tried.)


2005-02-07  Alexandre Duret-Lutz  <address@hidden>

        * aclocal.in ($serial_line_rx): Expect at least one space between
        `serial' and the following number.
        Report from Jim Meyering.
 
Index: aclocal.in
===================================================================
RCS file: /cvs/automake/automake/aclocal.in,v
retrieving revision 1.126
diff -u -r1.126 aclocal.in
--- aclocal.in  6 Feb 2005 12:33:31 -0000       1.126
+++ aclocal.in  7 Feb 2005 10:00:30 -0000
@@ -138,7 +138,7 @@
 my $m4_include_rx = "(?:m4_)?s?include\\((?:\\[([^]]+)\\]|([^],)\n]+))\\)";
 
 # Match a serial number
-my $serial_line_rx = '^#\s*serial\s*(\S*)';
+my $serial_line_rx = '^#\s*serial\s+(\S*)';
 my $serial_number_rx = '^\d+(?:\.\d+)*$';
 
 ################################################################

-- 
Alexandre Duret-Lutz