Re: FYI: s/$cygnus_mode/$options{'cygnus'}/

[Alexandre Duret-Lutz]

>>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:

 adl> On Tue, Jul 08, 2003 at 10:10:16AM +0200, Akim Demaille wrote:
 >> -    %options = ();
 >> +    %options =
 >> +      (
 >> +       # TRUE if --cygnus seen.
 >> +       'cygnus' => 0,
 >> +      );
 adl> [...]
 >> -  $options{'no-installinfo'} = $cygnus_mode;
 >> -  $options{'no-dependencies'} = $cygnus_mode;
 >> +  $options{'no-installinfo'} = $options{'cygnus'};
 >> +  $options{'no-dependencies'} = $options{'cygnus'};
 adl> [...]
 >> +  my %cli_options =
 >> (
 >> 'libdir:s'  => \$libdir,
 >> 'gnu'               => sub { &set_strictness ('gnu'); },
 >> 'gnits'             => sub { &set_strictness ('gnits'); },
 >> -     'cygnus'              => \$cygnus_mode,
 >> +     'cygnus'              => \$options{'cygnus'},

 adl> I've recently changed most (I thought all) of the %options values to
 adl> hold a Locations.  Especially, gnu_check_standards uses
 adl> $options{'no-installinfo'} as a Location.  (Obviously I forgot to
 adl> update these $cygnus_mode assignments.)  Anyway, wouldn't it look
 adl> better to use $options{'cygnus'} like the other options?  An option is
 adl> turned off if its key does not exist, and otherwise it contains the
 adl> Location of its definition.  But what is the Location of a command
 adl> line option?  An empty one?

This patch also introduced a bug.  %options is reset for each
file, so any setting done while parsing the command line
argument will be lost.  Presently the --cygnus command line
argument is completely ignored.  It's visible when you run
txinfo5.test (this test is an XFAIL, but it should fail because
some cygnus rule or variable is overridden --I don't remember--,
not for the current reason.)

-- 
Alexandre Duret-Lutz