Re: FYI: 6/ Automake::Variable & Automake::VarDef

[Raja R Harinath]

Hi,

Alexandre Duret-Lutz <address@hidden> writes:

>>>> "Hari" == Raja R Harinath <address@hidden> writes:
>
> [...]
>
>  >> What I've done is moving (2) into a separate function,
>  >> Variable::set_seen, so you can call rvar ('FOO')->set_seen
>  >> to mark a variable as examined in all conditions.
>
>  Hari> Isn't there already an API for this: 'examine_variable'.
>  Hari> Why a new name?
>
> As you noted in a previous mail, examine_variable was just an
> alias for variable_defined, so when I removed the latter I also
> removed the former.  Only later did I realize I really needed
> this functionality, and I named it set_seen because it is the
> Automake::Variable counterpart of Automake::VarDef::set_seen.

No problem.  I just wanted to make sure it is the same concept.

> I'll change this back to examine_variable, that's indeed more
> readable.  Perhaps I should also rename VarDef::set_seen and
> VarDef::seen to VarDef::examine and VarDef::examined ?

I think it's OK as is.  I have a couple of ideas I want to work on
Specifically, I want to change traverse_variable_recursively to work
on Automake::Variable's rather than strings.

(I'll be looking at it next week, too.  It'll depend on your patch,
so I'll wait for it to go in.)

- Hari
-- 
Raja R Harinath ------------------------------ address@hidden